You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@madlib.apache.org by GitBox <gi...@apache.org> on 2019/05/08 19:06:39 UTC
[GitHub] [madlib] kaknikhil commented on a change in pull request #385: DL:
Make metrics and loss optional compile parameters
kaknikhil commented on a change in pull request #385: DL: Make metrics and loss optional compile parameters
URL: https://github.com/apache/madlib/pull/385#discussion_r282206707
##########
File path: src/ports/postgres/modules/deep_learning/test/madlib_keras.sql_in
##########
@@ -318,7 +318,7 @@ SELECT madlib_keras_fit(
'independent_var',
'model_arch',
1,
- $$ optimizer=Adam(epsilon=None), loss=losses.categorical_crossentropy, metrics=['accuracy']$$::text,
+ $$ optimizer=Adam(epsilon=None), loss='categorical_crossentropy', metrics=['accuracy']$$::text,
Review comment:
we do not support the losses prefix (or any other prefix). The user has to pass in a string with the name of the unqualified loss function .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services