You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by gaohoward <gi...@git.apache.org> on 2015/08/24 03:43:50 UTC
[GitHub] activemq-artemis pull request: ARTEMIS-208 BrokerInfo issue, also:
GitHub user gaohoward opened a pull request:
https://github.com/apache/activemq-artemis/pull/132
ARTEMIS-208 BrokerInfo issue, also:
enlarged the default max size for tests to avoid send blocking.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gaohoward/activemq-artemis openwire-work2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/132.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #132
----
commit cf665a2e8e7c426e3e804fb6dd6b52c6e2ec5eca
Author: Howard Gao <ho...@gmail.com>
Date: 2015-08-24T01:04:29Z
ARTEMIS-208 BrokerInfo issue, also:
enlarged the default max size for tests to avoid send blocking.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-208 BrokerInfo issue, also:
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/132#issuecomment-134437430
@gaohoward BTW: most of our servers are going to be configured with 0.0.0.0... run a standard server..
Play with the openwire examples on Artemis... it doesn't work on them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-208 BrokerInfo issue, also:
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/132#issuecomment-134000025
Let me the one merging this ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-208 BrokerInfo issue, also:
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/132#issuecomment-134457021
No howard, the information is at the NettyConnection...
Please close this PR, I'm sending my own with your commit and an extra fix which I will ask your input
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-208 BrokerInfo issue, also:
Posted by gaohoward <gi...@git.apache.org>.
Github user gaohoward closed the pull request at:
https://github.com/apache/activemq-artemis/pull/132
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-208 BrokerInfo issue, also:
Posted by gaohoward <gi...@git.apache.org>.
Github user gaohoward commented on the pull request:
https://github.com/apache/activemq-artemis/pull/132#issuecomment-134456169
ok, I can get the information from netty server connection's configuration.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-208 BrokerInfo issue, also:
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/132#issuecomment-134293839
This fix will only work on tests....
on a default server, the acceptor will be at 0.0.0.0, and you will be sending tcp://0.0.0.0:port to the client.
It's also wrong to the fact that the same protocolManager will server multiple acceptors in case you have multiple ports configured. on that case you will be sending the BrokerInfo for a different port or IP.
Do you have the IP the user used to connect anywhere on the connection? So, you would have to create a brokerInfo per request.. instead caching a single one...
for that reason this fix is not valid!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-208 BrokerInfo issue, also:
Posted by gaohoward <gi...@git.apache.org>.
Github user gaohoward commented on the pull request:
https://github.com/apache/activemq-artemis/pull/132#issuecomment-134435057
yeah there is going to be a problem if acceptor is using 0.0.0.0. In that case we probably need a way to find the port which the client is connected to.
We cache the brokerInfo but not the brokerURL, you can see we do send a brokerInfo based on connection request, see method
ConnectionEntry createConnectionEntry(Acceptor acceptorUsed, Connection connection)
I think what's need to to is to pass a copy of brokerInfo to the new connection.
Thanks
Howard
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-208 BrokerInfo issue, also:
Posted by gaohoward <gi...@git.apache.org>.
Github user gaohoward commented on the pull request:
https://github.com/apache/activemq-artemis/pull/132#issuecomment-134458540
ok
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-208 BrokerInfo issue, also:
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/132#issuecomment-134436854
Please don't cache the BrokerInfo. Just create one based on the conversation between the client and server.
It's not a problem.. the current implementation is not fit for a production server... it needs to be fixed.
I don't remember how to get the IP the client used to connect now through the connection, but you certainly need that, and need the proper implementation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-208 BrokerInfo issue, also:
Posted by gaohoward <gi...@git.apache.org>.
Github user gaohoward commented on the pull request:
https://github.com/apache/activemq-artemis/pull/132#issuecomment-134000721
OK.
The brokerInfo command need to have a default URL so I added the method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---