[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #7160: arch: Change the linker generated symbols from uint32_t to uint8_t *

[GitBox <gi...@apache.org>]

gustavonihei commented on code in PR #7160:
URL: https://github.com/apache/incubator-nuttx/pull/7160#discussion_r978559084


##########
arch/xtensa/src/esp32s3/esp32s3_start.c:
##########
@@ -248,15 +248,15 @@ void noreturn_function IRAM_ATTR __esp32s3_start(void)
 
   /* Move CPU0 exception vectors to IRAM */
 
-  __asm__ __volatile__ ("wsr %0, vecbase\n"::"r" (&_init_start));
+  __asm__ __volatile__ ("wsr %0, vecbase\n"::"r" (_init_start));
 
   /* Clear .bss. We'll do this inline (vs. calling memset) just to be
    * certain that there are no issues with the state of global variables.
    */
 
-  for (uint32_t *dest = &_sbss; dest < &_ebss; dest++)
+  for (uint32_t dest = (uint32_t *)_sbss; dest < (uint32_t *)_ebss; )

Review Comment:
   ```suggestion
     for (uint32_t *dest = (uint32_t *)_sbss; dest < (uint32_t *)_ebss; )
   ```
   Part of this change seems wrong, `dest` should still be declared as a pointer to `uint32_t`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org