You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "amoghrajesh (via GitHub)" <gi...@apache.org> on 2026/08/12 11:40:52 UTC
[PR] Emit KPO reattach_on_restart deprecation warning irrespective of airflow version [airflow]
amoghrajesh opened a new pull request, #71492:
URL: https://github.com/apache/airflow/pull/71492
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull request.
Write a good git commit message following this guide: https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the documentation.
For user-facing UI changes, please attach before/after screenshots (or a short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
Provider deprecations are scoped to the provider's own release, not the Airflow version a user happens to run. Gating the warning on `AIRFLOW_V_3_3_PLUS` meant anyone on Airflow 3.0-3.2 passing `reattach_on_restart` never saw it, right up until the parameter is removed in a future provider release and their DAGs break with a `TypeError` instead. `durable` is a functional drop-in for `reattach_on_restart` on every supported version, so there's no reason to spare pre-3.3 users the warning.
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Emit KPO reattach_on_restart deprecation warning irrespective of airflow version [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on PR #71492:
URL: https://github.com/apache/airflow/pull/71492#issuecomment-5267008583
@eladkal durable is a plain, unconditional parameter on `KubernetesPodOperator.__init__`- no version check guards it, so functionally or documentation wise its not suggested but it's can potentially be provided.
So in practice, `durable=True` on Airflow 3.1 does exactly what `reattach_on_restart=True` did
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Emit KPO reattach_on_restart deprecation warning irrespective of airflow version [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on PR #71492:
URL: https://github.com/apache/airflow/pull/71492#issuecomment-5267802059
Let me move this to draft, I am clearing up some confusion in my head re this too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make KPO durable execution inert below Airflow 3.3 [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh merged PR #71492:
URL: https://github.com/apache/airflow/pull/71492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Emit KPO reattach_on_restart deprecation warning irrespective of airflow version [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on PR #71492:
URL: https://github.com/apache/airflow/pull/71492#issuecomment-5276431919
@eladkal thanks for the concern, its totally fair. I gave it some thought and fixed it properly now.
`durable` is now inert below Airflow 3.3, ie: setting it explicitly (True or False) only emits a warning that it has no effect there, and its value is otherwise ignored. `reattach_on_restart` (still defaulting to True, unchanged from before) is the only thing that controls the older / label search behaviour below 3.3.
So `durable` as a name is now reserved for the real, it is task-state-store based solution that _only exists on 3.3+_, it can't accidentally imply that on an earlier version. `reattach_on_restart` itself still emits the deprecation warning on every version, since its removal is tied to this provider's release schedule, not the caller's Airflow version and the warning message is just version aware about what to do next.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Emit KPO reattach_on_restart deprecation warning irrespective of airflow version [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #71492:
URL: https://github.com/apache/airflow/pull/71492#issuecomment-5266711208
> durable is a functional drop-in for reattach_on_restart on every supported version,
Is it? If I run Airflow 3.1 I won't have the durable parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Emit KPO reattach_on_restart deprecation warning irrespective of airflow version [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #71492:
URL: https://github.com/apache/airflow/pull/71492#issuecomment-5270689278
> So in practice, durable=True on Airflow 3.1 does exactly what reattach_on_restart=True did
I am a bit histated here. Durable is functionality that works only in 3.3+ while we made the parameter working for earlier versions. I'd like to avoid case where users of 3.1 expect durable functionality just because of the parameter name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org