You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/08/06 05:15:18 UTC

[GitHub] [ozone] ChenSammi commented on a change in pull request #2503: HDDS-5538. Uncaught NPE in GrpcReplicationService.

ChenSammi commented on a change in pull request #2503:
URL: https://github.com/apache/ozone/pull/2503#discussion_r683952784



##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/OnDemandContainerReplicationSource.java
##########
@@ -53,8 +55,10 @@ public void copyData(long containerId, OutputStream destination)
 
     Container container = controller.getContainer(containerId);
 
-    Preconditions.checkNotNull(
-        container, "Container is not found " + containerId);
+    if (container == null) {
+      throw new StorageContainerException("Container not found",

Review comment:
       Good point. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org