You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/03/27 06:18:24 UTC
[GitHub] [openwhisk-wskdebug] alexkli opened a new pull request #28: fix
mount-require not reloading all require() modules
alexkli opened a new pull request #28: fix mount-require not reloading all require() modules
URL: https://github.com/apache/openwhisk-wskdebug/pull/28
Fixes #9.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-wskdebug] rabbah merged pull request #28: fix
mount-require not reloading all require() modules
Posted by GitBox <gi...@apache.org>.
rabbah merged pull request #28: fix mount-require not reloading all require() modules
URL: https://github.com/apache/openwhisk-wskdebug/pull/28
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-wskdebug] alexkli commented on issue #28: fix
mount-require not reloading all require() modules
Posted by GitBox <gi...@apache.org>.
alexkli commented on issue #28: fix mount-require not reloading all require() modules
URL: https://github.com/apache/openwhisk-wskdebug/pull/28#issuecomment-604836959
@rabbah @dgrove-oss I kindly ask you for reviews as you've been helping out here before. I actually don't know the OW PR review policy... Right now I cannot merge myself without at least 1 review as I am not an admin of this repo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-wskdebug] alexkli commented on issue #28: fix
mount-require not reloading all require() modules
Posted by GitBox <gi...@apache.org>.
alexkli commented on issue #28: fix mount-require not reloading all require() modules
URL: https://github.com/apache/openwhisk-wskdebug/pull/28#issuecomment-605066946
@dgrove-oss Sounds good! Maybe donβt give me the Scala stuff π Node, Java, Scripts/Docker/Builds is fine, possibly Go.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-wskdebug] dgrove-oss commented on issue #28: fix
mount-require not reloading all require() modules
Posted by GitBox <gi...@apache.org>.
dgrove-oss commented on issue #28: fix mount-require not reloading all require() modules
URL: https://github.com/apache/openwhisk-wskdebug/pull/28#issuecomment-605023043
openwhisk has a policy across all the repos that all PRs have to have at least one approving review from a different committer than the person who submitted the PR. We're all expecting to be assigned reviews (and will assign you reviews too π on our PRs)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services