You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Hive QA (JIRA)" <ji...@apache.org> on 2014/11/17 11:07:33 UTC
[jira] [Commented] (HIVE-8895) bugs in mergejoin
[ https://issues.apache.org/jira/browse/HIVE-8895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14214478#comment-14214478 ]
Hive QA commented on HIVE-8895:
-------------------------------
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12681861/HIVE-8895.1.patch
{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 6647 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_auto_sortmerge_join_12
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_auto_sortmerge_join_12
{noformat}
Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/1819/testReport
Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/1819/console
Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-1819/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12681861 - PreCommit-HIVE-TRUNK-Build
> bugs in mergejoin
> -----------------
>
> Key: HIVE-8895
> URL: https://issues.apache.org/jira/browse/HIVE-8895
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Affects Versions: 0.13.0, 0.14.0, 0.13.1
> Reporter: cw
> Priority: Minor
> Labels: patch
> Attachments: HIVE-8895.1.patch
>
>
> I got a IndexOutOfBoundsException with a SQL in hive0.13.1. But it runs well on hive0.11. Here is the example sql which can trigger the exception.
> {code}
> create table test_join_1(a string, b string);
> create table test_join_2(a string, b string);
> -- got an IndexOutOfBoundsException error
> explain
> select * from
> (
> SELECT a a, b b
> FROM test_join_1
> )t1
> join
> (
> SELECT a a, b b
> FROM test_join_1
> )t2
> on t1.a = t2.a
> and t1.a = t2.b
> join
> (
> select a from test_join_2
> )t3 on t1.a = t3.a;
> {code}
> And here is some stack information:
> {code}
> java.lang.IndexOutOfBoundsException: Index: 1, Size: 1
> at java.util.ArrayList.rangeCheck(ArrayList.java:604)
> at java.util.ArrayList.get(ArrayList.java:382)
> at org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.mergeJoins(SemanticAnalyzer.java:7403)
> at org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.mergeJoinTree(SemanticAnalyzer.java:7616)
> at org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genPlan(SemanticAnalyzer.java:8946)
> at org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.analyzeInternal(SemanticAnalyzer.java:9220)
> ...
> {code}
> But sql as below runs well.
> {code}
> explain select * from
> (
> SELECT a a, b b
> FROM test_join_1
> )t1
> join
> (
> SELECT a a, b b
> FROM test_join_1
> )t2
> on t1.a = t2.a
> and t2.a = t2.b
> join
> (
> select a from test_join_2
> )t3 on t1.a = t3.a;
> {code}
> I didn't quite understand the details of mergejoin. But I noticed the patch in HIVE-5556 edited SemanticAnalyzer.java with the change below:
> {code}
> - if ((targetCondn == null) || (nodeCondn.size() != targetCondn.size())) {
> - return -1;
> + if ( targetCondn == null ) {
> + return new ObjectPair(-1, null);
> + }
> {code}
> Maybe it's a good idea to revert the logic of the 'if' statement as before.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)