You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by FelipeAdorno <gi...@git.apache.org> on 2015/05/03 21:02:14 UTC
[GitHub] commons-lang pull request: EqualsExlcude notation, HashCodeExclude...
GitHub user FelipeAdorno opened a pull request:
https://github.com/apache/commons-lang/pull/77
EqualsExlcude notation, HashCodeExclude notation and ToStringExludeNotat...
New pullrequest for fixing all code reviews.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/FelipeAdorno/commons-lang master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-lang/pull/77.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #77
----
commit aeb6f86bcdec061ee9c6be96066fa19c56523490
Author: Felipe Adorno <fe...@gmail.com>
Date: 2015-05-03T18:59:00Z
EqualsExlcude notation, HashCodeExclude notation and ToStringExludeNotation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: EqualsExlcude notation, HashCodeExclude...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/commons-lang/pull/77
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: EqualsExlcude notation, HashCodeExclude...
Posted by britter <gi...@git.apache.org>.
Github user britter commented on the pull request:
https://github.com/apache/commons-lang/pull/77#issuecomment-98812854
Nice work @FelipeAdorno! Kudos for fighting through the review process.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: EqualsExlcude notation, HashCodeExclude...
Posted by FelipeAdorno <gi...@git.apache.org>.
Github user FelipeAdorno commented on the pull request:
https://github.com/apache/commons-lang/pull/77#issuecomment-98561837
sorry @britter, I remove author tag.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: EqualsExlcude notation, HashCodeExclude...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the pull request:
https://github.com/apache/commons-lang/pull/77#issuecomment-98525535
[](https://coveralls.io/builds/2476741)
Coverage decreased (-0.01%) to 93.3% when pulling **aeb6f86bcdec061ee9c6be96066fa19c56523490 on FelipeAdorno:master** into **8e7ea70a33ecb8db5207849ea6371b4a5a8ffd26 on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: EqualsExlcude notation, HashCodeExclude...
Posted by britter <gi...@git.apache.org>.
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/77#discussion_r29559457
--- Diff: src/main/java/org/apache/commons/lang3/builder/EqualsExclude.java ---
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.commons.lang3.builder;
+
+import java.lang.annotation.ElementType;
+import java.lang.annotation.Retention;
+import java.lang.annotation.Target;
+import static java.lang.annotation.RetentionPolicy.RUNTIME;
+
+/**
+ * Use this annotation to builds a equals excluding the annotated field.
+ * @author Felipe Adorno (felipeadsc@gmail.com)
--- End diff --
We don't use the author tag, but instead attribute contributions in the contributors section of [pom.xml](pom.xml). Would it be okay for you to remove the author tags?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: EqualsExlcude notation, HashCodeExclude...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the pull request:
https://github.com/apache/commons-lang/pull/77#issuecomment-98561910
[](https://coveralls.io/builds/2477798)
Coverage decreased (-0.01%) to 93.3% when pulling **4daaeabaad5ea11d25c0079fea40b7f9d0fe83a3 on FelipeAdorno:master** into **8e7ea70a33ecb8db5207849ea6371b4a5a8ffd26 on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: EqualsExlcude notation, HashCodeExclude...
Posted by britter <gi...@git.apache.org>.
Github user britter commented on the pull request:
https://github.com/apache/commons-lang/pull/77#issuecomment-98530541
Very nice, thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---