[GitHub] [spark] MaxGekk commented on issue #26031: [SPARK-29362][SQL] Move timestamp expressions and tests to separate files

[GitBox <gi...@apache.org>]

MaxGekk commented on issue #26031: [SPARK-29362][SQL] Move timestamp expressions and tests to separate files
URL: https://github.com/apache/spark/pull/26031#issuecomment-538694870
 
 
   > Yeah it's a big file but there are lots of date/time functions, and they're related.
   
   Large file is only one reason. Another one is date expressions and timestamp expressions in `datetimeExpressions.scala` are not related. They don't depend on each other. This is the only one place where we mixed 2 types, probably because of historical reasons.
   
   > ... this will cause a few merge conflict problems ...
   
   It seems this is main concern, right? As far as I understand, if a private Spark fork has additional date or timestamp expressions, this will cause some conflicts. ... but such conflicts could be easily resolved by keeping an expression in the same place (date expression) or just move it to `timestampExpressions.scala`. Is it real problem?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org