You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "Ethan Guo (Jira)" <ji...@apache.org> on 2022/03/28 22:57:00 UTC

[jira] [Closed] (HUDI-3720) Rollback reattempt fails if the commit to roll back is not present

     [ https://issues.apache.org/jira/browse/HUDI-3720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ethan Guo closed HUDI-3720.
---------------------------
    Resolution: Fixed

> Rollback reattempt fails if the commit to roll back is not present
> ------------------------------------------------------------------
>
>                 Key: HUDI-3720
>                 URL: https://issues.apache.org/jira/browse/HUDI-3720
>             Project: Apache Hudi
>          Issue Type: Bug
>          Components: writer-core
>            Reporter: Ethan Guo
>            Assignee: Ethan Guo
>            Priority: Blocker
>              Labels: pull-request-available
>             Fix For: 0.11.0
>
>
> Let's say C4 (RB_C1) is rolling back C1.  If C4 fails just after the instant files of C1 are deleted and before C4 is transitioned from inflight to complete, next time when C4 rollback action is reattempted, the rollback cannot finish, due to the logic below, since the instant to rollback is not present.
>  
> {code:java}
> BaseHoodieWriteClient
> public boolean rollback(final String commitInstantTime, Option<HoodiePendingRollbackInfo> pendingRollbackInfo, boolean skipLocking) throws HoodieRollbackException {
> ...
> if (commitInstantOpt.isPresent()) {
> ...
> } else {
>   LOG.warn("Cannot find instant " + commitInstantTime + " in the timeline, for rollback");
>   return false;
> } {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)