You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org> on 2008/08/21 11:18:45 UTC
[jira] Created: (QPID-1255) SimpleACLTest
testClientPublishInvalidQueueSuccess intermittent failure in CI
SimpleACLTest testClientPublishInvalidQueueSuccess intermittent failure in CI
-----------------------------------------------------------------------------
Key: QPID-1255
URL: https://issues.apache.org/jira/browse/QPID-1255
Project: Qpid
Issue Type: Bug
Affects Versions: M3
Reporter: Martin Ritchie
Assignee: Martin Ritchie
Fix For: M3
Summary:
This test has been failing on and off since yesterdays changes. The test utilises session.createTemporaryQueue() which was changed yesterday to actually create the queue on the broker.
The test may now be incorrect as a result of the now correctly functioning createTemporaryQueue()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (QPID-1255) SimpleACLTest
testClientPublishInvalidQueueSuccess intermittent failure in CI
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Ritchie reassigned QPID-1255:
------------------------------------
Assignee: (was: Martin Ritchie)
As statedin commit this temporary commit applieed to allow CI systems to help diagnose cause of race condition did just that:
org.apache.qpid.AMQTimeoutException: Server did not respond in a timely fashion [error code 408: Request Timeout]
at org.apache.qpid.client.util.BlockingWaiter.block(BlockingWaiter.java:176)
at org.apache.qpid.client.protocol.BlockingMethodFrameListener.blockForFrame(BlockingMethodFrameListener.java:127)
at org.apache.qpid.client.protocol.AMQProtocolHandler.writeCommandFrameAndWaitForReply(AMQProtocolHandler.java:664)
at org.apache.qpid.client.protocol.AMQProtocolHandler.syncWrite(AMQProtocolHandler.java:685)
at org.apache.qpid.client.protocol.AMQProtocolHandler.syncWrite(AMQProtocolHandler.java:679)
at org.apache.qpid.client.AMQSession_0_8.sendCreateQueue(AMQSession_0_8.java:146)
at org.apache.qpid.client.AMQSession$3.execute(AMQSession.java:1051)
at org.apache.qpid.client.failover.FailoverRetrySupport.execute(FailoverRetrySupport.java:119)
at org.apache.qpid.client.AMQSession.createQueue(AMQSession.java:1047)
at org.apache.qpid.client.AMQSession.createQueue(AMQSession.java:1027)
at org.apache.qpid.client.AMQSession.createTemporaryQueue(AMQSession.java:1206)
at org.apache.qpid.server.security.acl.SimpleACLTest.testClientPublishInvalidQueueSuccess(SimpleACLTest.java:293)
My guess is that the session is open but closes right after the isClosed call is done. So the client the goes on and does a waitForFrame that never arrives causing the timeout exceptions. As commented in AMQPH if we add our frame listener such that it will receive any existing and subsequent exceptions, such as connection closing whilst we add them to the framelisteners then I think this will resolve the issue.
> SimpleACLTest testClientPublishInvalidQueueSuccess intermittent failure in CI
> -----------------------------------------------------------------------------
>
> Key: QPID-1255
> URL: https://issues.apache.org/jira/browse/QPID-1255
> Project: Qpid
> Issue Type: Bug
> Affects Versions: M3
> Reporter: Martin Ritchie
> Fix For: M3
>
>
> Summary:
> This test has been failing on and off since yesterdays changes. The test utilises session.createTemporaryQueue() which was changed yesterday to actually create the queue on the broker.
> The test may now be incorrect as a result of the now correctly functioning createTemporaryQueue()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (QPID-1255) SimpleACLTest
testClientPublishInvalidQueueSuccess intermittent failure in CI
Posted by "Rob Godfrey (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rob Godfrey resolved QPID-1255.
-------------------------------
Resolution: Fixed
Nothing to review
> SimpleACLTest testClientPublishInvalidQueueSuccess intermittent failure in CI
> -----------------------------------------------------------------------------
>
> Key: QPID-1255
> URL: https://issues.apache.org/jira/browse/QPID-1255
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Tests
> Affects Versions: M3
> Reporter: Martin Ritchie
> Assignee: Rob Godfrey
> Fix For: M4
>
>
> Summary:
> This test has been failing on and off since yesterdays changes. The test utilises session.createTemporaryQueue() which was changed yesterday to actually create the queue on the broker.
> The test may now be incorrect as a result of the now correctly functioning createTemporaryQueue()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (QPID-1255) SimpleACLTest
testClientPublishInvalidQueueSuccess intermittent failure in CI
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12642490#action_12642490 ]
Martin Ritchie commented on QPID-1255:
--------------------------------------
The reason for the strange test failures could be due to two issues.
1) QPID-1394, the client and broker compete to register their respective SASL plugins however the broker should always win but if the broker fails to register then non of the Qpid SASL plugins will be available and authentication cannot take place. This is probably the most likely cause of the sasl errors Qpid-1394 ensures that the client and broker do not compete to register using the same name for their sasl providers.
2) QPID-1390 could mean that the wrong SASL plugin is being used for authentication as the broker does not remove the custom SASL providers on shutdown. This update ensures that on shutdown they are removed so should prevent any further problems.
> SimpleACLTest testClientPublishInvalidQueueSuccess intermittent failure in CI
> -----------------------------------------------------------------------------
>
> Key: QPID-1255
> URL: https://issues.apache.org/jira/browse/QPID-1255
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Tests
> Affects Versions: M3
> Reporter: Martin Ritchie
> Fix For: M4
>
>
> Summary:
> This test has been failing on and off since yesterdays changes. The test utilises session.createTemporaryQueue() which was changed yesterday to actually create the queue on the broker.
> The test may now be incorrect as a result of the now correctly functioning createTemporaryQueue()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-1255) SimpleACLTest
testClientPublishInvalidQueueSuccess intermittent failure in CI
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Ritchie updated QPID-1255:
---------------------------------
Status: Ready To Review (was: In Progress)
> SimpleACLTest testClientPublishInvalidQueueSuccess intermittent failure in CI
> -----------------------------------------------------------------------------
>
> Key: QPID-1255
> URL: https://issues.apache.org/jira/browse/QPID-1255
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Tests
> Affects Versions: M3
> Reporter: Martin Ritchie
> Fix For: M4
>
>
> Summary:
> This test has been failing on and off since yesterdays changes. The test utilises session.createTemporaryQueue() which was changed yesterday to actually create the queue on the broker.
> The test may now be incorrect as a result of the now correctly functioning createTemporaryQueue()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (QPID-1255) SimpleACLTest
testClientPublishInvalidQueueSuccess intermittent failure in CI
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Ritchie reassigned QPID-1255:
------------------------------------
Assignee: Rob Godfrey
Hi Rob can you review these changes to the SimpleACLTest please.
The commits were split between two sub JIRAs and this is the additional JIRA, QPID-1182 being the first for SimpleACLTest.
> SimpleACLTest testClientPublishInvalidQueueSuccess intermittent failure in CI
> -----------------------------------------------------------------------------
>
> Key: QPID-1255
> URL: https://issues.apache.org/jira/browse/QPID-1255
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Tests
> Affects Versions: M3
> Reporter: Martin Ritchie
> Assignee: Rob Godfrey
> Fix For: M4
>
>
> Summary:
> This test has been failing on and off since yesterdays changes. The test utilises session.createTemporaryQueue() which was changed yesterday to actually create the queue on the broker.
> The test may now be incorrect as a result of the now correctly functioning createTemporaryQueue()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-1255) SimpleACLTest
testClientPublishInvalidQueueSuccess intermittent failure in CI
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Ritchie updated QPID-1255:
---------------------------------
Component/s: Java Tests
Java Broker
> SimpleACLTest testClientPublishInvalidQueueSuccess intermittent failure in CI
> -----------------------------------------------------------------------------
>
> Key: QPID-1255
> URL: https://issues.apache.org/jira/browse/QPID-1255
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Tests
> Affects Versions: M3
> Reporter: Martin Ritchie
> Fix For: M4
>
>
> Summary:
> This test has been failing on and off since yesterdays changes. The test utilises session.createTemporaryQueue() which was changed yesterday to actually create the queue on the broker.
> The test may now be incorrect as a result of the now correctly functioning createTemporaryQueue()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (QPID-1255) SimpleACLTest
testClientPublishInvalidQueueSuccess intermittent failure in CI
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12642486#action_12642486 ]
Martin Ritchie commented on QPID-1255:
--------------------------------------
Commits to address this issue have been made against QPID-1390 and QPID-1394/QPID-1393
Enable the SimpleACLTest for InVM testing only. External Testing is blocked on QPID-1103
http://svn.apache.org/viewcvs.cgi//incubator/qpid/trunk/qpid/java/08ExcludeList/?rev=707657&view=diff&r1=707657&r2=707656&p1=/incubator/qpid/trunk/qpid/java/08ExcludeList&p2=/incubator/qpid/trunk/qpid/java/08ExcludeList
Update to the SimpleACLTest was erroneously checked in with the QPID-1394/QIPD-1393 change:
http://svn.apache.org/viewcvs.cgi//incubator/qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/server/security/acl/SimpleACLTest.java/?rev=707658&view=diff&r1=707658&r2=707657&p1=/incubator/qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/server/security/acl/SimpleACLTest.java&p2=/incubator/qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/server/security/acl/SimpleACLTest.java
> SimpleACLTest testClientPublishInvalidQueueSuccess intermittent failure in CI
> -----------------------------------------------------------------------------
>
> Key: QPID-1255
> URL: https://issues.apache.org/jira/browse/QPID-1255
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Tests
> Affects Versions: M3
> Reporter: Martin Ritchie
> Fix For: M4
>
>
> Summary:
> This test has been failing on and off since yesterdays changes. The test utilises session.createTemporaryQueue() which was changed yesterday to actually create the queue on the broker.
> The test may now be incorrect as a result of the now correctly functioning createTemporaryQueue()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.