You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "john-bodley (via GitHub)" <gi...@apache.org> on 2023/06/16 04:05:06 UTC
[GitHub] [superset] john-bodley opened a new pull request, #24415: chore: Remove obsolete Druid NoSQL REGEX operator
john-bodley opened a new pull request, #24415:
URL: https://github.com/apache/superset/pull/24415
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
Whilst reading over [this](https://github.com/apache/superset/blob/b44d20348de4199b4eaf3663ddb23650b21a3dd9/superset/models/helpers.py#L1785-L1800) code I realized that the `REGEX` filter operator is unused—a byproduct of the Druid NoSQL connector which has been removed.
This PR removes the obsolete options from the UI controls to prevent erroneous backend errors.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
#### BEFORE
<img width="317" alt="Screenshot 2023-06-15 at 8 52 53 PM" src="https://github.com/apache/superset/assets/4567245/967de2e2-2bad-44b4-8a91-dc1a4b635f58">
#### AFTER
<img width="319" alt="Screenshot 2023-06-15 at 8 52 26 PM" src="https://github.com/apache/superset/assets/4567245/1386d1ed-5931-4803-a1e9-d8abee8c54f1">
### TESTING INSTRUCTIONS
CI.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24415: chore: Remove obsolete Druid NoSQL REGEX operator
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24415:
URL: https://github.com/apache/superset/pull/24415#issuecomment-1594069843
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24415?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24415](https://app.codecov.io/gh/apache/superset/pull/24415?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (8b81cc7) into [master](https://app.codecov.io/gh/apache/superset/commit/23bb1c48a13236b47cdbff65f3de6658204e7168?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (23bb1c4) will **decrease** coverage by `10.90%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 8b81cc7 differs from pull request most recent head ab3e235. Consider uploading reports for the commit ab3e235 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24415 +/- ##
===========================================
- Coverage 68.91% 58.02% -10.90%
===========================================
Files 1904 1904
Lines 73920 73918 -2
Branches 8119 8119
===========================================
- Hits 50944 42892 -8052
- Misses 20865 28915 +8050
Partials 2111 2111
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `53.84% <ø> (-0.01%)` | :arrow_down: |
| python | `60.59% <ø> (-22.69%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `54.62% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24415?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/explore/constants.ts](https://app.codecov.io/gh/apache/superset/pull/24415?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29uc3RhbnRzLnRz) | `100.00% <ø> (ø)` | |
| [superset/utils/core.py](https://app.codecov.io/gh/apache/superset/pull/24415?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `66.13% <ø> (-25.42%)` | :arrow_down: |
... and [301 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24415/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley merged pull request #24415: chore: Remove obsolete Druid NoSQL REGEX operator
Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley merged PR #24415:
URL: https://github.com/apache/superset/pull/24415
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org