You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/10/03 00:23:05 UTC
[PR] GH-37984: [Release] Use ISO 8601 format for YAML date value [arrow]
kou opened a new pull request, #37985:
URL: https://github.com/apache/arrow/pull/37985
### Rationale for this change
If we use ISO 8601 format for date value, we can use the value as a `Date` object in Jekyll. It's easy to reuse.
Use case: https://github.com/apache/arrow-site/pull/408
### What changes are included in this PR?
Use ISO 8601 format.
### Are these changes tested?
No.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-37984: [Release] Use ISO 8601 format for YAML date value [arrow]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #37985:
URL: https://github.com/apache/arrow/pull/37985#discussion_r1343828194
##########
dev/release/post-03-website.sh:
##########
@@ -58,6 +58,7 @@ fi
export TZ=UTC
release_date=$(LC_TIME=C date "+%-d %B %Y")
+release_date_iso8601=$(LC_TIME=C date "+%Y-%m-%d")
Review Comment:
I double checked that this command generates the correct date format:
```shell
$ LC_TIME=C date "+%Y-%m-%d"
2023-10-03
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-37984: [Release] Use ISO 8601 format for YAML date value [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #37985:
URL: https://github.com/apache/arrow/pull/37985
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-37984: [Release] Use ISO 8601 format for YAML date value [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #37985:
URL: https://github.com/apache/arrow/pull/37985#issuecomment-1745679715
Thanks for double checking!
I'll merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-37984: [Release] Use ISO 8601 format for YAML date value [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37985:
URL: https://github.com/apache/arrow/pull/37985#issuecomment-1743966898
:warning: GitHub issue #37984 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-37984: [Release] Use ISO 8601 format for YAML date value [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #37985:
URL: https://github.com/apache/arrow/pull/37985#issuecomment-1746088197
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 45588a77af3548720dc64fc8ae917e469e6f106a.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/17376186200) has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org