You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/08/15 10:21:56 UTC
[GitHub] [helix] pkuwm opened a new pull request #1276: Add build status badge to README
pkuwm opened a new pull request #1276:
URL: https://github.com/apache/helix/pull/1276
### Issues
- [ ] My PR addresses the following Helix issues and references them in the PR description:
Fixes #1275
### Description
- [ ] Here are some details about my PR, including screenshots of any UI changes:
We need to know the project builds successfully for each commit. And indicate the project build is passing in README.
Result as below:
### Tests
- [ ] The following tests are written for this issue:
(List the names of added unit/integration tests)
- [ ] The following is the result of the "mvn test" command on the appropriate module:
(Before CI test pass, please copy & paste the result of "mvn test")
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm commented on pull request #1276: Add status badges to README
Posted by GitBox <gi...@apache.org>.
pkuwm commented on pull request #1276:
URL: https://github.com/apache/helix/pull/1276#issuecomment-677968702
Thanks, @jiajunwang, for the review and approval.
This PR is ready to be merged, approved by @jiajunwang
Add Helix logo and build status badges to README
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm merged pull request #1276: Add status badges to README
Posted by GitBox <gi...@apache.org>.
pkuwm merged pull request #1276:
URL: https://github.com/apache/helix/pull/1276
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on pull request #1276: Add status badges to README
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on pull request #1276:
URL: https://github.com/apache/helix/pull/1276#issuecomment-675186022
Note this is the mirror of the Apache Helix repo.
I'm not sure if we want to introduce GitHub related features to any files that are outside .github. Maybe not.
@dasahcc @lei-xia What's your opinion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org