You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/15 04:07:16 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #793:
boards/Board.mk: use genromfs to make romfs image
xiaoxiang781216 opened a new pull request #793: boards/Board.mk: use genromfs to make romfs image
URL: https://github.com/apache/incubator-nuttx/pull/793
With this patch, user can use RCSRCS or RCRAW specify which files need put into romfs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #793: boards/Board.mk: use genromfs to make romfs image
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #793: boards/Board.mk: use genromfs to make romfs image
URL: https://github.com/apache/incubator-nuttx/pull/793#discussion_r408684022
##########
File path: boards/Board.mk
##########
@@ -37,6 +37,27 @@
-include $(TOPDIR)/Make.defs
+ifneq ($(RCSRCS)$(RCRAWS),)
+ETCDIR := etctmp
+ETCSRC := $(ETCDIR:%=%.c)
+
+CSRCS += $(ETCSRC)
+
+RCOBJS = $(RCSRCS:%=%$(OBJEXT))
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #793: boards/Board.mk:
use genromfs to make romfs image
Posted by GitBox <gi...@apache.org>.
yamt commented on issue #793: boards/Board.mk: use genromfs to make romfs image
URL: https://github.com/apache/incubator-nuttx/pull/793#issuecomment-614635791
i guess the README needs to be updated. esp. the "Updating the ROMFS File System" section.
otherwise lgtm.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #793:
boards/Board.mk: use genromfs to make romfs image
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #793: boards/Board.mk: use genromfs to make romfs image
URL: https://github.com/apache/incubator-nuttx/pull/793#discussion_r408622729
##########
File path: boards/Board.mk
##########
@@ -37,6 +37,27 @@
-include $(TOPDIR)/Make.defs
+ifneq ($(RCSRCS)$(RCRAWS),)
+ETCDIR := etctmp
+ETCSRC := $(ETCDIR:%=%.c)
+
+CSRCS += $(ETCSRC)
+
+RCOBJS = $(RCSRCS:%=%$(OBJEXT))
Review comment:
is OBJEXT appropriate for this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #793:
boards/Board.mk: use genromfs to make romfs image
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #793: boards/Board.mk: use genromfs to make romfs image
URL: https://github.com/apache/incubator-nuttx/pull/793#issuecomment-613910592
> > With this patch, user can use RCSRCS or RCRAW specify which files need put into romfs.
>
> i guess some documentation is necessary.
@anchao will provide a document.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #793:
boards/Board.mk: use genromfs to make romfs image
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #793: boards/Board.mk: use genromfs to make romfs image
URL: https://github.com/apache/incubator-nuttx/pull/793#discussion_r408623934
##########
File path: boards/Board.mk
##########
@@ -37,6 +37,27 @@
-include $(TOPDIR)/Make.defs
+ifneq ($(RCSRCS)$(RCRAWS),)
+ETCDIR := etctmp
+ETCSRC := $(ETCDIR:%=%.c)
+
+CSRCS += $(ETCSRC)
+
+RCOBJS = $(RCSRCS:%=%$(OBJEXT))
+
+$(RCOBJS): %$(OBJEXT): %
+ $(call PREPROCESS, $<, $@)
+ $(Q) mkdir -p $(dir $(ETCDIR)$(DELIM)$<)
+ $(Q) cp -r $@ $(ETCDIR)$(DELIM)$<
+
+$(ETCSRC): $(shell find $(RCRAWS) -type l) $(RCOBJS)
Review comment:
why do you list symbolic links here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #793:
boards/Board.mk: use genromfs to make romfs image
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #793: boards/Board.mk: use genromfs to make romfs image
URL: https://github.com/apache/incubator-nuttx/pull/793#discussion_r408626544
##########
File path: boards/Board.mk
##########
@@ -138,6 +164,8 @@ endif
clean:
$(call DELFILE, libboard$(LIBEXT))
+ $(call DELFILE, $(ETCSRC))
+ $(call DELDIR, $(ETCDIR))
Review comment:
clean RCOBJS here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #793:
boards/Board.mk: use genromfs to make romfs image
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #793: boards/Board.mk: use genromfs to make romfs image
URL: https://github.com/apache/incubator-nuttx/pull/793#issuecomment-614127387
> > Yes, we will convert one config to utilize the new method which will:
> > 1.Ensure the new method work in all supported platform
> > 2.Demostrate how to use the new method to simplify the work
>
> A page on the Confluence Wiki would probably be even better. A config is good for testing, but it is not good for documenting or communicating.
Ok, @anchao will find a time to document the new method, but the workflow is very simple now. User just need add script or file to RCSRCS/RCRAWS and then the build system will do all the thing automatically. No need to understand genromfs, xxd and nsh_romfsimg.h anymore.
@yamt The first patch address all your issue.
@patacongo @davids5 the second patch demo how simple and flexible with the new method
Of course the old method still work as before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #793:
boards/Board.mk: use genromfs to make romfs image
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #793: boards/Board.mk: use genromfs to make romfs image
URL: https://github.com/apache/incubator-nuttx/pull/793#issuecomment-614043994
> It has always been a policy not to add any new tools to the build process. If tools are added, the must be fully verified on all build platforms and documented in the top level README.txt file. We must clearly advise people how to set up the environment on every supported platform.
Yes, we will convert one config to utilize the new method which will:
1.Ensure the new method work in all supported platform
2.Demostrate how to use the new method to simplify the work
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #793:
boards/Board.mk: use genromfs to make romfs image
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #793: boards/Board.mk: use genromfs to make romfs image
URL: https://github.com/apache/incubator-nuttx/pull/793#issuecomment-614010694
It has always been a policy not to add any new tools to the build process. If tools are added, the must be fully verified on all build platforms and documented in the top level README.txt file. We must clearly advise people how to set up the environment on every supported platform.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #793:
boards/Board.mk: use genromfs to make romfs image
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #793: boards/Board.mk: use genromfs to make romfs image
URL: https://github.com/apache/incubator-nuttx/pull/793#issuecomment-613852943
> what will use this ?
Now NuttX use mkromfs.sh+Kconfig to generate the romfs content which is very difficult to modify. With RCSRCS and RCRAWS, user can add any files to romfs:
1.Files in RCSRCS is processed by C preprocessor which is useful for the shell script
2.Files in RCRAWS is directly put into romfs which is sutiable for some binary content
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #793: boards/Board.mk:
use genromfs to make romfs image
Posted by GitBox <gi...@apache.org>.
yamt commented on issue #793: boards/Board.mk: use genromfs to make romfs image
URL: https://github.com/apache/incubator-nuttx/pull/793#issuecomment-613837920
> With this patch, user can use RCSRCS or RCRAW specify which files need put into romfs.
i guess some documentation is necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo merged pull request #793:
boards/Board.mk: use genromfs to make romfs image
Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #793: boards/Board.mk: use genromfs to make romfs image
URL: https://github.com/apache/incubator-nuttx/pull/793
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #793: boards/Board.mk: use genromfs to make romfs image
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #793: boards/Board.mk: use genromfs to make romfs image
URL: https://github.com/apache/incubator-nuttx/pull/793#discussion_r408683931
##########
File path: boards/Board.mk
##########
@@ -37,6 +37,27 @@
-include $(TOPDIR)/Make.defs
+ifneq ($(RCSRCS)$(RCRAWS),)
+ETCDIR := etctmp
+ETCSRC := $(ETCDIR:%=%.c)
+
+CSRCS += $(ETCSRC)
+
+RCOBJS = $(RCSRCS:%=%$(OBJEXT))
+
+$(RCOBJS): %$(OBJEXT): %
+ $(call PREPROCESS, $<, $@)
+ $(Q) mkdir -p $(dir $(ETCDIR)$(DELIM)$<)
+ $(Q) cp -r $@ $(ETCDIR)$(DELIM)$<
+
+$(ETCSRC): $(shell find $(RCRAWS) -type l) $(RCOBJS)
+ $(foreach raw,$(RCRAWS), \
+ $(shell cp --parents -rfLp $(raw) $(ETCDIR)))
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #793:
boards/Board.mk: use genromfs to make romfs image
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on issue #793: boards/Board.mk: use genromfs to make romfs image
URL: https://github.com/apache/incubator-nuttx/pull/793#issuecomment-613898005
> is this an alternative to NSH_CUSTOMROMFS?
>
RCSRCS/RCRAWS isn't an alternative which is designed to work with NSH_ROMFSETC/NSH_ARCHROMFS/NSH_CUSTOMROMFS. In the old workflow, if user enable NSH_ROMFSETC, he/she need prepare nsh_romfsimg.h by self or utilize mkromfs.sh(but this approach is only suitable for demo purpose). In the new workflow, user just need:
1.Enable NSH_ROMFSETC
2.Append script files into RCSRCS
2.Append binary files to RCRAWS
Then the build system will automatically generate romfs.img and convert to header file for you.
> how is a user supposed to specify RCSRCS and RCRAWS?
Here is a demo boards/arm/chip/board/src/Makefile
```
RCSRCS := rcS
VPATH += :etc/init.d
DEPPATH += --dep-path etc/init.d
include $(TOPDIR)/boards/Board.mk
```
And boards/arm/chip/board/src/etc/init.d/rcS
```
#include <nuttx/config.h>
#ifdef CONFIG_NSH_PROC_MOUNTPOINT
mount -t procfs CONFIG_NSH_PROC_MOUNTPOINT
#endif
#ifdef CONFIG_FS_TMPFS
mount -t tmpfs CONFIG_LIBC_TMPDIR
#endif
#ifndef CONFIG_NSH_DISABLE_UNAME
uname -a > /dev/syslog
#endif
```
Of course, user could add more script or config files to RCSRCS/RCRAWS, the only between RCSRCS and RCRAWS is that RCSRCS will go through C preprocessor but RCRAWS not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #793:
boards/Board.mk: use genromfs to make romfs image
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #793: boards/Board.mk: use genromfs to make romfs image
URL: https://github.com/apache/incubator-nuttx/pull/793#issuecomment-614697784
> i guess the README needs to be updated. esp. the "Updating the ROMFS File System" section.
> otherwise lgtm.
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #793: boards/Board.mk: use genromfs to make romfs image
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #793: boards/Board.mk: use genromfs to make romfs image
URL: https://github.com/apache/incubator-nuttx/pull/793#discussion_r408684088
##########
File path: boards/Board.mk
##########
@@ -37,6 +37,27 @@
-include $(TOPDIR)/Make.defs
+ifneq ($(RCSRCS)$(RCRAWS),)
+ETCDIR := etctmp
+ETCSRC := $(ETCDIR:%=%.c)
+
+CSRCS += $(ETCSRC)
+
+RCOBJS = $(RCSRCS:%=%$(OBJEXT))
+
+$(RCOBJS): %$(OBJEXT): %
+ $(call PREPROCESS, $<, $@)
+ $(Q) mkdir -p $(dir $(ETCDIR)$(DELIM)$<)
+ $(Q) cp -r $@ $(ETCDIR)$(DELIM)$<
+
+$(ETCSRC): $(shell find $(RCRAWS) -type l) $(RCOBJS)
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #793:
boards/Board.mk: use genromfs to make romfs image
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #793: boards/Board.mk: use genromfs to make romfs image
URL: https://github.com/apache/incubator-nuttx/pull/793#issuecomment-614135676
> Ok, @anchao will find some time to document the new method, but the workflow is very simple now. User just need add script or file to RCSRCS/RCRAWS and then the build system will do all the thing automatically. No need to understand genromfs, xxd and nsh_romfsimg.h anymore.
I can help with the writing so don't let the language differences be a barrier to communicating well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #793:
boards/Board.mk: use genromfs to make romfs image
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #793: boards/Board.mk: use genromfs to make romfs image
URL: https://github.com/apache/incubator-nuttx/pull/793#issuecomment-614042673
> @xiaoxiang781216 -
>
> > RCSRCS/RCRAWS isn't an alternative which is designed to work with NSH_ROMFSETC/NSH_ARCHROMFS/NSH_CUSTOMROMFS.
>
> I am confused by the statement. " isn't an alternative"
>
> To be clear: Will the old way still work Yes or No?
>
> If the answer is No. This change should not come in, without deprecating the old way and announcing its End Of Life at a future time.
Of course, the old method still can be used without any change, we seldom provide a solution stop the old way. If the compatiblity can't achieve, we will provide the patch to convert all usage to the new method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #793:
boards/Board.mk: use genromfs to make romfs image
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on issue #793: boards/Board.mk: use genromfs to make romfs image
URL: https://github.com/apache/incubator-nuttx/pull/793#issuecomment-614127387
> > Yes, we will convert one config to utilize the new method which will:
> > 1.Ensure the new method work in all supported platform
> > 2.Demostrate how to use the new method to simplify the work
>
> A page on the Confluence Wiki would probably be even better. A config is good for testing, but it is not good for documenting or communicating.
Ok, @anchao will find some time to document the new method, but the workflow is very simple now. User just need add script or file to RCSRCS/RCRAWS and then the build system will do all the thing automatically. No need to understand genromfs, xxd and nsh_romfsimg.h anymore.
@yamt The first patch address all your issue.
@patacongo @davids5 the second patch demo how simple and flexible with the new method
Of course the old method still work as before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on issue #793: boards/Board.mk:
use genromfs to make romfs image
Posted by GitBox <gi...@apache.org>.
davids5 commented on issue #793: boards/Board.mk: use genromfs to make romfs image
URL: https://github.com/apache/incubator-nuttx/pull/793#issuecomment-614057770
@xiaoxiang781216 - that is all good. I think the wording was just not clear: "it is an alternative"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #793:
boards/Board.mk: use genromfs to make romfs image
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #793: boards/Board.mk: use genromfs to make romfs image
URL: https://github.com/apache/incubator-nuttx/pull/793#discussion_r408589066
##########
File path: boards/Board.mk
##########
@@ -37,6 +37,27 @@
-include $(TOPDIR)/Make.defs
+ifneq ($(RCSRCS)$(RCRAWS),)
+ETCDIR := etctmp
+ETCSRC := $(ETCDIR:%=%.c)
+
+CSRCS += $(ETCSRC)
+
+RCOBJS = $(RCSRCS:%=%$(OBJEXT))
+
+$(RCOBJS): %$(OBJEXT): %
+ $(call PREPROCESS, $<, $@)
+ $(Q) mkdir -p $(dir $(ETCDIR)$(DELIM)$<)
+ $(Q) cp -r $@ $(ETCDIR)$(DELIM)$<
+
+$(ETCSRC): $(shell find $(RCRAWS) -type l) $(RCOBJS)
+ $(foreach raw,$(RCRAWS), \
+ $(shell cp --parents -rfLp $(raw) $(ETCDIR)))
Review comment:
i suspect --parents is not portable.
usually -R is preferred over -r these days. do you need -r?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #793: boards/Board.mk: use genromfs to make romfs image
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #793: boards/Board.mk: use genromfs to make romfs image
URL: https://github.com/apache/incubator-nuttx/pull/793#discussion_r408685797
##########
File path: boards/Board.mk
##########
@@ -138,6 +164,8 @@ endif
clean:
$(call DELFILE, libboard$(LIBEXT))
+ $(call DELFILE, $(ETCSRC))
+ $(call DELDIR, $(ETCDIR))
Review comment:
RCOBJ is put into ETCDIR, so remove $(ETCDIR) is enough.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #793:
boards/Board.mk: use genromfs to make romfs image
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #793: boards/Board.mk: use genromfs to make romfs image
URL: https://github.com/apache/incubator-nuttx/pull/793#issuecomment-614067035
> Yes, we will convert one config to utilize the new method which will:
> 1.Ensure the new method work in all supported platform
> 2.Demostrate how to use the new method to simplify the work
A page on the Confluence Wiki would probably be even better. A config is good for testing, but it is not good for documenting or communicating.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #793:
boards/Board.mk: use genromfs to make romfs image
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #793: boards/Board.mk: use genromfs to make romfs image
URL: https://github.com/apache/incubator-nuttx/pull/793#issuecomment-613898005
> is this an alternative to NSH_CUSTOMROMFS?
>
RCSRCS/RCRAWS isn't an alternative which is designed to work with NSH_ROMFSETC/NSH_ARCHROMFS/NSH_CUSTOMROMFS. In the old workflow, if user enable NSH_ROMFSETC, he/she need prepare nsh_romfsimg.h by self or utilize mkromfs.sh(but this approach is only suitable for demo purpose). In the new workflow, user just need:
1.Enable NSH_ROMFSETC
2.Append script files into RCSRCS
2.Append binary files to RCRAWS
The build system will automatically generate romfs.img and convert to header file for you.
> how is a user supposed to specify RCSRCS and RCRAWS?
Here is a demo boards/arm/chip/board/src/Makefile
```
RCSRCS := rcS
VPATH += :etc/init.d
DEPPATH += --dep-path etc/init.d
include $(TOPDIR)/boards/Board.mk
```
And boards/arm/chip/board/src/etc/init.d/rcS
```
#include <nuttx/config.h>
#ifdef CONFIG_NSH_PROC_MOUNTPOINT
mount -t procfs CONFIG_NSH_PROC_MOUNTPOINT
#endif
#ifdef CONFIG_FS_TMPFS
mount -t tmpfs CONFIG_LIBC_TMPDIR
#endif
#ifndef CONFIG_NSH_DISABLE_UNAME
uname -a > /dev/syslog
#endif
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services