You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2019/10/14 20:41:51 UTC

[GitHub] [incubator-iceberg] manishmalhotrawork edited a comment on issue #524: respect commit.manifest.min.count

manishmalhotrawork edited a comment on issue #524: respect commit.manifest.min.count
URL: https://github.com/apache/incubator-iceberg/pull/524#issuecomment-541908787
 
 
   @rdblue Sorry, missed your question !
   this PR is trying to resolve #490 
   
   When we add new manifests by calling `appendManifests(...)` , then the `commit.manifest.min-count-to-merge` property is ignored and manifests are getting merged.
   This happens because of `MergingSnapshotProducer` checks `commit.manifest.min-count-to-merge` property along with if the `cachedNewManifest` is present in list of manifests. And `cachedNewManifest` is created when new files are added and not manifest files.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org