You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/25 20:06:26 UTC

[GitHub] [arrow-datafusion] Dandandan commented on a change in pull request #339: Speed up `create_batch_from_map`

Dandandan commented on a change in pull request #339:
URL: https://github.com/apache/arrow-datafusion/pull/339#discussion_r639146388



##########
File path: datafusion/src/scalar.rs
##########
@@ -381,19 +380,74 @@ impl ScalarValue {
                                 )))
                             }
                         })
-                        .collect::<Result<Vec<_>>>()?;
-
-                    // it is annoying that one can not create

Review comment:
       FYI @alamb also saw some opportunity simplifying / optimizing `build_array_primitive` / `build_array_string`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org