[GitHub] [iceberg] nastra commented on a diff in pull request #6073: Core: Pass purgeRequested flag to REST server

[GitBox <gi...@apache.org>]

nastra commented on code in PR #6073:
URL: https://github.com/apache/iceberg/pull/6073#discussion_r1008114969


##########
core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java:
##########
@@ -222,8 +222,8 @@ public static LoadTableResponse createTable(
     throw new IllegalStateException("Cannot wrap catalog that does not produce BaseTable");
   }
 
-  public static void dropTable(Catalog catalog, TableIdentifier ident) {
-    boolean dropped = catalog.dropTable(ident);
+  public static void dropTable(Catalog catalog, TableIdentifier ident, boolean purge) {
+    boolean dropped = catalog.dropTable(ident, purge);

Review Comment:
   I think we have a discrepancy in behavior between [Catalog.dropTable(ident)](https://github.com/apache/iceberg/blob/master/api/src/main/java/org/apache/iceberg/catalog/Catalog.java#L295) (purges by default) and [SessionCatalog.dropTable(..)](https://github.com/apache/iceberg/blob/master/api/src/main/java/org/apache/iceberg/catalog/SessionCatalog.java#L179-L188) (does not purge by default and therefore also has `SessionCatalog.purgeTable(..)`)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org