You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by blrunner <gi...@git.apache.org> on 2015/11/19 10:35:53 UTC

[GitHub] tajo pull request: TAJO-1960: Separate HDFS space handler and S3 s...

GitHub user blrunner opened a pull request:

    https://github.com/apache/tajo/pull/868

    TAJO-1960: Separate HDFS space handler and S3 space handler

    I implemented ```S3TableSpace``` by copying ```FileTableSpace``` and added some unit test cases. But I've yet to test this patch on AWS.
    Open a pull request
    Create a new pull request by comparing changes across two branches. If you need to, you can also compare across forks.
    base fork: apache/tajo   base: master  ...  head fork: blrunner/tajo   compare: TAJO-1960  Able to merge. These branches can be automatically merged.
     @blrunner
    
     Styling with Markdown is supported
    Write Preview
    
    Attach files by dragging & dropping or  selecting them.
    Create pull request
     4 commits
     5 files changed
     0 commit comments
     1 contributor


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/blrunner/tajo TAJO-1960

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/868.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #868
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1960: Separate HDFS space handler and S3 s...

Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:

    https://github.com/apache/tajo/pull/868#issuecomment-160504533
  
    I found that the patch runs as expected with master branch on EMR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1960: Separate HDFS space handler and S3 s...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/tajo/pull/868


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1960: Separate HDFS space handler and S3 s...

Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:

    https://github.com/apache/tajo/pull/868#issuecomment-160551087
  
    +1
    @blrunner Ship it. The patch looks good to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1960: Separate HDFS space handler and S3 s...

Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:

    https://github.com/apache/tajo/pull/868#issuecomment-159764194
  
    I have a question. Is it just copied from FileTablespace? or you changed some code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1960: Separate HDFS space handler and S3 s...

Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:

    https://github.com/apache/tajo/pull/868#issuecomment-158306439
  
    I've finished the test successfully on AWS as following:
    
    * Tajo version: Use branch-0.11.1 because EMR default version for JDK is JDK 1.7. You can see codes for branch-0.11.1 at https://github.com/blrunner/tajo/tree/TAJO-1960-branch-0.11.1 .
    * EMR version: 4.1.0
    * DataSet : TPC-H 1G
    * Bootstrap : 
    ```
    aws emr create-cluster \
        --name="<cluster_name>" \
        --release-label=emr-4.1.0 \
        --no-auto-terminate \
        --use-default-roles \
        --ec2-attributes KeyName=<userId> \
        --instance-groups InstanceGroupType=MASTER,InstanceCount=1,InstanceType=m3.xlarge InstanceGroupType=CORE,InstanceCount=3,InstanceType=c3.xlarge \
        --bootstrap-action Name="Install tajo",Path=s3://tajo-emr/emr-4.x/install-tajo.py,Args=["-t","<tarball_path>","-c","s3://tajo-emr/tajo-0.11.0/template/c3.xlarge/conf"]
    ```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1960: Separate HDFS space handler and S3 s...

Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:

    https://github.com/apache/tajo/pull/868#issuecomment-159776067
  
    Hi @hyunsik 
    
    I just copied from FileTableSpace.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---