You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "PurelyApplied (GitHub)" <gi...@apache.org> on 2018/12/03 18:57:16 UTC
[GitHub] [geode] PurelyApplied opened pull request #2936: GEODE-6123:
Be consistent in dependency declaration style.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/2936 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] moleske commented on pull request #2936: GEODE-6123:
Be consistent in dependency declaration style.
Posted by "moleske (GitHub)" <gi...@apache.org>.
I thought groovy allowed something like `integrationTestCompile("junit:junit:${project.'junit.version'}")`? But I find consistency `>` groovy conventions.
[ Full content available at: https://github.com/apache/geode/pull/2936 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] dickcav closed pull request #2936: GEODE-6123: Be
consistent in dependency declaration style.
Posted by "dickcav (GitHub)" <gi...@apache.org>.
[ pull request closed by dickcav ]
[ Full content available at: https://github.com/apache/geode/pull/2936 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] PurelyApplied commented on pull request #2936:
GEODE-6123: Be consistent in dependency declaration style.
Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
I would actually prefer the string interpolation, since I think that is more readable. But I also believe that consistency is the more important thing here.
Also, in the longer term, we'll do away with all of this `+ project.'lib.version'` stuff. Gradle 5 has dependency constraints ([Gradle docs here](https://docs.gradle.org/current/userguide/managing_transitive_dependencies.html)), but they're currently not playing nicely with the `maven-publish` plugin we use. Alternatively, there's Spring's Gradle Dependency Management plugin ([here](https://github.com/spring-gradle-plugins/dependency-management-plugin)), but I haven't had the chance to look meaningfully at that yet.
[ Full content available at: https://github.com/apache/geode/pull/2936 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] moleske commented on pull request #2936: GEODE-6123:
Be consistent in dependency declaration style.
Posted by "moleske (GitHub)" <gi...@apache.org>.
More out of curiosity than actually caring, but how do we feel about the `()`? Noticed below they are not used.
[ Full content available at: https://github.com/apache/geode/pull/2936 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] PurelyApplied commented on pull request #2936:
GEODE-6123: Be consistent in dependency declaration style.
Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
Huh. Parens are supposed to be added by `spotlessGroovyGradleApply`, but it looks like `buildSrc` is considered part of the `rootProject` by Gradle, rather than a `subproject` of the root. And `spotless` is only getting applied to `subprojects` rather than `allprojects`.
I'll open a separate PR to fix that. Thanks for noticing!
[ Full content available at: https://github.com/apache/geode/pull/2936 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] moleske commented on pull request #2936: GEODE-6123:
Be consistent in dependency declaration style.
Posted by "moleske (GitHub)" <gi...@apache.org>.
more of curiosity than actually caring, but how do we feel about the `()`? Noticed below they are not used.
[ Full content available at: https://github.com/apache/geode/pull/2936 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] PurelyApplied commented on pull request #2936:
GEODE-6123: Be consistent in dependency declaration style.
Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
Huh. Parens are supposed to be added by `spotlessGroovyGradleApply`, but it looks like `buildSrc` is considered part of the `rootProject` by Gradle, rather than a `subproject` of the root.
I'll open a separate PR to fix that. Thanks for noticing!
[ Full content available at: https://github.com/apache/geode/pull/2936 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org