You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/08/11 05:50:34 UTC
[GitHub] [apisix-ingress-controller] chzhuo opened a new pull request #622: bugfix: fix kube config field tag omitempty
chzhuo opened a new pull request #622:
URL: https://github.com/apache/apisix-ingress-controller/pull/622
### Bugfix
- Description
Using `clientset` to create `ApisixRoute` will get error `spec.http.backend: Invalid value: "null"` when only set `backends`
- Related issues:
#621
- How to fix?
adding `omitempty` to `not-required` field
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #622: bugfix: fix kube config field tag omitempty
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #622:
URL: https://github.com/apache/apisix-ingress-controller/pull/622#issuecomment-896541952
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/622?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#622](https://codecov.io/gh/apache/apisix-ingress-controller/pull/622?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (938b502) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/f78248a6aca0ac4754fd4d5d410c28f1cdd3d9c7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f78248a) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/622?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #622 +/- ##
=======================================
Coverage 34.79% 34.79%
=======================================
Files 57 57
Lines 5722 5722
=======================================
Hits 1991 1991
Misses 3492 3492
Partials 239 239
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/622?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/622?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f78248a...938b502](https://codecov.io/gh/apache/apisix-ingress-controller/pull/622?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] lgy1027 commented on pull request #622: bugfix: add tag omitempty for the fields in some data structures
Posted by GitBox <gi...@apache.org>.
lgy1027 commented on pull request #622:
URL: https://github.com/apache/apisix-ingress-controller/pull/622#issuecomment-899944752
请问下我是安装最新的helm，还是说代码中引入的依赖升到最新版本解决这个问题？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #622: bugfix: add tag omitempty for the fields in some data structures
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #622:
URL: https://github.com/apache/apisix-ingress-controller/pull/622#issuecomment-896745135
@chzhuo I rewrote the title to make it more semantic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 merged pull request #622: bugfix: add tag omitempty for the fields in some data structures
Posted by GitBox <gi...@apache.org>.
tao12345666333 merged pull request #622:
URL: https://github.com/apache/apisix-ingress-controller/pull/622
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org