You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/11 10:33:19 UTC
[GitHub] [cloudstack] shwstppr opened a new pull request #4683: ui: fix systevmtype for create service offering form
shwstppr opened a new pull request #4683:
URL: https://github.com/apache/cloudstack/pull/4683
### Description
Fixes #4682
Adds systemvmtype param in API call
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4683: ui: fix systevmtype for create service offering form
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4683:
URL: https://github.com/apache/cloudstack/pull/4683#issuecomment-777348485
@blueorangutan ui
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4683: ui: fix systevmtype for create service offering form
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4683:
URL: https://github.com/apache/cloudstack/pull/4683#issuecomment-783999272
@shwstppr I see more than 2 OKs and manual testing has been done. Do we need more or do you want to merge now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4683: ui: fix systevmtype for create service offering form
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4683:
URL: https://github.com/apache/cloudstack/pull/4683#issuecomment-784000968
@DaanHoogland ready for merge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4683: ui: fix systevmtype for create service offering form
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4683:
URL: https://github.com/apache/cloudstack/pull/4683#issuecomment-777349326
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4683: ui: fix systevmtype for create service offering form
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4683:
URL: https://github.com/apache/cloudstack/pull/4683#issuecomment-777354099
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4683 (JID-3836)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #4683: ui: fix systevmtype for create service offering form
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #4683:
URL: https://github.com/apache/cloudstack/pull/4683
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org