You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrii Tkach <at...@hortonworks.com> on 2017/01/04 12:48:17 UTC
Review Request 55172: Cover JournalNode HA wizard with unit tests
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55172/
-----------------------------------------------------------
Review request for Ambari and Aleksandr Kovalenko.
Bugs: AMBARI-19361
https://issues.apache.org/jira/browse/AMBARI-19361
Repository: ambari
Description
-------
Cover JournalNode HA wizard with unit tests
Diffs
-----
ambari-web/app/assets/test/tests.js 4263016
ambari-web/app/controllers/main/admin/highAvailability/journalNode/progress_controller.js 436a8bd
ambari-web/app/controllers/main/admin/highAvailability/journalNode/step1_controller.js e1252b7
ambari-web/app/controllers/main/admin/highAvailability/journalNode/step2_controller.js d1cb198
ambari-web/app/controllers/main/admin/highAvailability/journalNode/step4_controller.js 1938527
ambari-web/app/controllers/main/admin/highAvailability/journalNode/step6_controller.js 262fe93
ambari-web/app/controllers/main/admin/highAvailability/journalNode/step7_controller.js add2070
ambari-web/app/controllers/main/admin/highAvailability/journalNode/wizard_controller.js fe9a15b
ambari-web/test/controllers/main/admin/highAvailability/journalNode/progress_controller_test.js PRE-CREATION
ambari-web/test/controllers/main/admin/highAvailability/journalNode/step1_controller_test.js PRE-CREATION
ambari-web/test/controllers/main/admin/highAvailability/journalNode/step2_controller_test.js PRE-CREATION
ambari-web/test/controllers/main/admin/highAvailability/journalNode/step4_controller_test.js PRE-CREATION
ambari-web/test/controllers/main/admin/highAvailability/journalNode/step6_controller_test.js PRE-CREATION
ambari-web/test/controllers/main/admin/highAvailability/journalNode/step7_controller_test.js PRE-CREATION
ambari-web/test/controllers/main/admin/highAvailability/journalNode/step8_controller_test.js PRE-CREATION
ambari-web/test/controllers/main/admin/highAvailability/journalNode/wizard_controller_test.js PRE-CREATION
Diff: https://reviews.apache.org/r/55172/diff/
Testing
-------
19935 passing (28s)
153 pending
Thanks,
Andrii Tkach
Re: Review Request 55172: Cover JournalNode HA wizard with unit tests
Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55172/#review160484
-----------------------------------------------------------
Ship it!
Ship It!
- Aleksandr Kovalenko
On \u042f\u043d\u0432. 4, 2017, 12:48 \u043f.\u043f., Andrii Tkach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55172/
> -----------------------------------------------------------
>
> (Updated \u042f\u043d\u0432. 4, 2017, 12:48 \u043f.\u043f.)
>
>
> Review request for Ambari and Aleksandr Kovalenko.
>
>
> Bugs: AMBARI-19361
> https://issues.apache.org/jira/browse/AMBARI-19361
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Cover JournalNode HA wizard with unit tests
>
>
> Diffs
> -----
>
> ambari-web/app/assets/test/tests.js 4263016
> ambari-web/app/controllers/main/admin/highAvailability/journalNode/progress_controller.js 436a8bd
> ambari-web/app/controllers/main/admin/highAvailability/journalNode/step1_controller.js e1252b7
> ambari-web/app/controllers/main/admin/highAvailability/journalNode/step2_controller.js d1cb198
> ambari-web/app/controllers/main/admin/highAvailability/journalNode/step4_controller.js 1938527
> ambari-web/app/controllers/main/admin/highAvailability/journalNode/step6_controller.js 262fe93
> ambari-web/app/controllers/main/admin/highAvailability/journalNode/step7_controller.js add2070
> ambari-web/app/controllers/main/admin/highAvailability/journalNode/wizard_controller.js fe9a15b
> ambari-web/test/controllers/main/admin/highAvailability/journalNode/progress_controller_test.js PRE-CREATION
> ambari-web/test/controllers/main/admin/highAvailability/journalNode/step1_controller_test.js PRE-CREATION
> ambari-web/test/controllers/main/admin/highAvailability/journalNode/step2_controller_test.js PRE-CREATION
> ambari-web/test/controllers/main/admin/highAvailability/journalNode/step4_controller_test.js PRE-CREATION
> ambari-web/test/controllers/main/admin/highAvailability/journalNode/step6_controller_test.js PRE-CREATION
> ambari-web/test/controllers/main/admin/highAvailability/journalNode/step7_controller_test.js PRE-CREATION
> ambari-web/test/controllers/main/admin/highAvailability/journalNode/step8_controller_test.js PRE-CREATION
> ambari-web/test/controllers/main/admin/highAvailability/journalNode/wizard_controller_test.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/55172/diff/
>
>
> Testing
> -------
>
> 19935 passing (28s)
> 153 pending
>
>
> Thanks,
>
> Andrii Tkach
>
>