Re: cvs commit: modperl-2.0/xs/Apache/SubProcess Apache__SubProcess.h

[Stas Bekman <st...@stason.org>]

dougm@apache.org wrote:

> dougm       01/12/17 19:21:22
> 
>   Modified:    xs/Apache/SubProcess Apache__SubProcess.h
>   Log:
>   a few style fixups and comments

>   +    if (!(*script_in = procnew->in)) {
>   +        /* XXX: this needs to be Perl_croak(aTHX_ ...)
>   +         * or go away so we can compile with -DPERL_CORE
>   +         */
>            croak("broken program-in stream");
>            return APR_EBADF;
>        }


I must have copied it from some other place in mod_perl. I've grepped 
around and there are a few places where there is croak and not 
Perl_croak, even when we have pTHX_ proto. e.g.:

./xs/Apache/Filter/Apache__Filter.h



-- 


_____________________________________________________________________
Stas Bekman             JAm_pH      --   Just Another mod_perl Hacker
http://stason.org/      mod_perl Guide   http://perl.apache.org/guide
mailto:stas@stason.org  http://ticketmaster.com http://apacheweek.com
http://singlesheaven.com http://perl.apache.org http://perlmonth.com/


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org