You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/03/30 19:26:41 UTC
[jira] [Commented] (SAMZA-1176) Make TestJoinOperator unit tests
safe for concurrent execution
[ https://issues.apache.org/jira/browse/SAMZA-1176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15949651#comment-15949651 ]
ASF GitHub Bot commented on SAMZA-1176:
---------------------------------------
GitHub user prateekm opened a pull request:
https://github.com/apache/samza/pull/105
SAMZA-1176: Make TestJoinOperator unit tests safe for concurrent execution
There are occasional failures like the following:
```joinRetainsMatchedMessagesReverse FAILED
java.lang.AssertionError: expected:<0> but was:<110>
at org.junit.Assert.fail(Assert.java:91)
at org.junit.Assert.failNotEquals(Assert.java:645)
at org.junit.Assert.assertEquals(Assert.java:126)
at org.junit.Assert.assertEquals(Assert.java:470)
at org.junit.Assert.assertEquals(Assert.java:454)
at org.apache.samza.operators.TestJoinOperator.joinRetainsMatchedMessagesReverse(TestJoinOperator.java:174)```
These are presumably due to concurrent JUnit test execution. This change is to isolate these test cases so that they can be run concurrently.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prateekm/samza join-tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/105.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #105
----
commit fbb48e49d46d5912d8ece1d36e1d74dd7f11ef0c
Author: Prateek Maheshwari <pm...@linkedin.com>
Date: 2017-03-30T19:09:22Z
SAMZA-1176: Make TestJoinOperator unit tests safe for concurrent execution
----
> Make TestJoinOperator unit tests safe for concurrent execution
> --------------------------------------------------------------
>
> Key: SAMZA-1176
> URL: https://issues.apache.org/jira/browse/SAMZA-1176
> Project: Samza
> Issue Type: Bug
> Affects Versions: 0.13.0
> Reporter: Prateek Maheshwari
> Assignee: Prateek Maheshwari
> Fix For: 0.13.0
>
>
> There are occasional failures like the following:
> ```joinRetainsMatchedMessagesReverse FAILED
> java.lang.AssertionError: expected:<0> but was:<110>
> at org.junit.Assert.fail(Assert.java:91)
> at org.junit.Assert.failNotEquals(Assert.java:645)
> at org.junit.Assert.assertEquals(Assert.java:126)
> at org.junit.Assert.assertEquals(Assert.java:470)
> at org.junit.Assert.assertEquals(Assert.java:454)
> at org.apache.samza.operators.TestJoinOperator.joinRetainsMatchedMessagesReverse(TestJoinOperator.java:174)```
> These are presumably due to concurrent JUnit test execution. This ticket is to isolate these test cases so that they can be run concurrently.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)