[GitHub] spark pull request: [SPARK-10620] [SPARK-13054] Minor addendum to ...

[andrewor14 <gi...@git.apache.org>]

Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10958#discussion_r51510044
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala ---
    @@ -1144,13 +1144,12 @@ class DAGScheduler(
             null
           }
     
    -    // The success case is dealt with separately below.
    -    // TODO: Why post it only for failed tasks in cancelled stages? Clarify semantics here.
    -    if (event.reason != Success) {
    -      val attemptId = task.stageAttemptId
    -      listenerBus.post(SparkListenerTaskEnd(
    -        stageId, attemptId, taskType, event.reason, event.taskInfo, taskMetrics))
    -    }
    +    // Note: this stage may already have been canceled, in which case this task end event
    +    // maybe posted after the stage completed event. There's not much we can do here without
    +    // introducing additional complexity in the scheduler to wait for all the task end events
    +    // before posting the stage completed event.
    +    listenerBus.post(SparkListenerTaskEnd(
    +      stageId, task.stageAttemptId, taskType, event.reason, event.taskInfo, taskMetrics))
    --- End diff --
    
    (comment for linking)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org