You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/26 15:34:25 UTC

[GitHub] [airflow] XD-DENG commented on a change in pull request #13906: Make webserver rolling update

XD-DENG commented on a change in pull request #13906:
URL: https://github.com/apache/airflow/pull/13906#discussion_r564603095



##########
File path: chart/templates/webserver/webserver-deployment.yaml
##########
@@ -39,7 +39,7 @@ spec:
   strategy:
     type: RollingUpdate
     rollingUpdate:
-      maxUnavailable: 1
+      maxUnavailable: 0

Review comment:
       The original code (`maxUnavailable: 1`) already looks good to me when `replicas` >=2.
   
   It's possible that users explicitly specify the `replicas` to 1, for some purposes. In that case, users take the responsibility and should be aware of the result.
   
   Please correct me if I misunderstand/miss anything.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org