You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cxf.apache.org by GitBox <gi...@apache.org> on 2021/05/27 08:51:10 UTC

[GitHub] [cxf] eberntsen edited a comment on pull request #795: [CXF-8535] Query missing from signature request-target

eberntsen edited a comment on pull request #795:
URL: https://github.com/apache/cxf/pull/795#issuecomment-849457831


   Fixed checkstyle issues now.
   
   The previous unit tests didn't fail previously because they didn't target any classes that had any issues. They don't fail now either because I haven't touched the existing methods, only added methods that tested other classes. The problem here was that the tests only manually tested the inner Signer/Verifier classes with test data that matches the spec, but was different from what they would receive from the Interceptor/Filter. The issue was with the Interceptor/Filter layer. The Interceptor/Filter didn't give the inner classes the same input as the tests did.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org