You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/03/06 08:35:32 UTC
[GitHub] [incubator-pinot] kishoreg commented on issue #3913: Adding the
support for sampling logs
kishoreg commented on issue #3913: Adding the support for sampling logs
URL: https://github.com/apache/incubator-pinot/pull/3913#issuecomment-470017142
can we set a maxRate instead of setting samplingRate? we can use the RateLimiter from Gauva to implement this for now. This will make the rate adaptive and at low qps, we will still get all the logs unlike sampling where it will always filter.
We can then move to BurstFilter (https://logging.apache.org/log4j/2.0/manual/filters.html#BurstFilter) when we move to log4j2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org