[GitHub] [lucene] jpountz commented on a change in pull request #466: LUCENE-10168: Only test N-2 codecs on nightly runs.

[GitBox <gi...@apache.org>]

jpountz commented on a change in pull request #466:
URL: https://github.com/apache/lucene/pull/466#discussion_r754892231



##########
File path: lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene70/IndexedDISI.java
##########
@@ -1,326 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements.  See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License.  You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.apache.lucene.backward_codecs.lucene70;
-
-import java.io.DataInput;
-import java.io.IOException;
-import org.apache.lucene.search.DocIdSetIterator;
-import org.apache.lucene.store.IndexInput;
-import org.apache.lucene.store.IndexOutput;
-import org.apache.lucene.util.BitSetIterator;
-import org.apache.lucene.util.FixedBitSet;
-import org.apache.lucene.util.RoaringDocIdSet;
-
-/**
- * Disk-based implementation of a {@link DocIdSetIterator} which can return the index of the current
- * document, i.e. the ordinal of the current document among the list of documents that this iterator
- * can return. This is useful to implement sparse doc values by only having to encode values for
- * documents that actually have a value.
- *
- * <p>Implementation-wise, this {@link DocIdSetIterator} is inspired of {@link RoaringDocIdSet
- * roaring bitmaps} and encodes ranges of {@code 65536} documents independently and picks between 3
- * encodings depending on the density of the range:
- *
- * <ul>
- *   <li>{@code ALL} if the range contains 65536 documents exactly,
- *   <li>{@code DENSE} if the range contains 4096 documents or more; in that case documents are
- *       stored in a bit set,
- *   <li>{@code SPARSE} otherwise, and the lower 16 bits of the doc IDs are stored in a {@link
- *       DataInput#readShort() short}.
- * </ul>
- *
- * <p>Only ranges that contain at least one value are encoded.
- *
- * <p>This implementation uses 6 bytes per document in the worst-case, which happens in the case
- * that all ranges contain exactly one document.
- *
- * @lucene.internal
- */
-final class IndexedDISI extends DocIdSetIterator {

Review comment:
       This was dead code, hence the removal.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org