[GitHub] [activemq-artemis] gtully commented on a diff in pull request #4466: ARTEMIS-4256 - support removal of configuration via properties

["gtully (via GitHub)" <gi...@apache.org>]

gtully commented on code in PR #4466:
URL: https://github.com/apache/activemq-artemis/pull/4466#discussion_r1185862241


##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/config/ActiveMQDefaultConfiguration.java:
##########
@@ -569,8 +569,12 @@ public static String getDefaultHapolicyBackupStrategy() {
 
    public static final String BROKER_PROPERTIES_KEY_SURROUND = "\"";
 
+   public static final String BROKER_PROPERTIES_REMOVE_VALUE = "-";

Review Comment:
   interesting, thanks for the link. This is exactly the sort of thing we should be aware of and follow, convention over configuration etc.
   However, in this case, I think the semantic of that is a little different, it is a null value, where the key still exists. x=null
   x=- means remove x. 
   I am not sure if there is any case in artemis config where we want to have a collection with a null entry.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org