You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/05/12 18:33:47 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #3706: board: Enable CONFIG_BOARDCTL_ROMDISK

xiaoxiang781216 opened a new pull request #3706:
URL: https://github.com/apache/incubator-nuttx/pull/3706


   ## Summary
   to fix build break by commit 3156aa7532c5097c9
   
   ## Impact
   
   ## Testing
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3706: board: Enable CONFIG_BOARDCTL_ROMDISK

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3706:
URL: https://github.com/apache/incubator-nuttx/pull/3706#issuecomment-840239156


   Fix here: https://github.com/apache/incubator-nuttx-apps/pull/712


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton commented on pull request #3706: board: Enable CONFIG_BOARDCTL_ROMDISK

Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #3706:
URL: https://github.com/apache/incubator-nuttx/pull/3706#issuecomment-840598064


   sim:posix_spawn needs to be in the sim02.dat exclude list instead of sim01.dat


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] davids5 commented on pull request #3706: board: Enable CONFIG_BOARDCTL_ROMDISK

Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #3706:
URL: https://github.com/apache/incubator-nuttx/pull/3706#issuecomment-840435835


   Restarted and it is still failing - CI is current failures. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3706: board: Enable CONFIG_BOARDCTL_ROMDISK

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #3706:
URL: https://github.com/apache/incubator-nuttx/pull/3706


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3706: board: Enable CONFIG_BOARDCTL_ROMDISK

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3706:
URL: https://github.com/apache/incubator-nuttx/pull/3706#issuecomment-840649008


   Since my PR fix the build break, I will merge it directly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton commented on pull request #3706: board: Enable CONFIG_BOARDCTL_ROMDISK

Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #3706:
URL: https://github.com/apache/incubator-nuttx/pull/3706#issuecomment-840060210


   Still failing 
   ```
   elf_main.c: In function 'elf_main':
   Error: elf_main.c:209:29: error: unused variable 'desc' [-Werror=unused-variable]
     209 |   struct boardioc_romdisk_s desc;
         |                             ^~~~
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org