You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Brian Wickman <wi...@apache.org> on 2015/03/05 21:31:13 UTC
Review Request 31774: Add aurora-specific entry point for thermos
observer and fix /vars
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31774/
-----------------------------------------------------------
Review request for Aurora, Joe Smith and Zameer Manji.
Bugs: AURORA-1133
https://issues.apache.org/jira/browse/AURORA-1133
Repository: aurora
Description
-------
Just like the aurora-specific thermos entry point, adds an aurora-specific thermos_observer entry point. Just allows it to search for thermos runners in /var/lib/thermos and also relative to mesos sandboxes.
Diffs
-----
src/main/python/apache/aurora/tools/BUILD 36117b4199bc52873ca3abdb1ef6447437a81bb0
src/main/python/apache/aurora/tools/thermos_observer.py PRE-CREATION
src/main/python/apache/thermos/observer/BUILD 28995b99b4991e17eb977583388c89e753055e9b
src/main/python/apache/thermos/observer/bin/BUILD a42dbf321b8dcf5d64b22c2a480c3f4e3bad2a42
src/main/python/apache/thermos/observer/bin/thermos_observer.py 213a48eb4e2441b88fd6b608d1f3ba7dd0f2b859
src/main/python/apache/thermos/observer/http/BUILD cc8eb7793b980a6a4b76deece759e12e9bc7fcb0
src/main/python/apache/thermos/observer/http/configure.py PRE-CREATION
src/main/python/apache/thermos/observer/http/diagnostics.py PRE-CREATION
src/main/python/apache/thermos/observer/http/vars_endpoint.py PRE-CREATION
src/main/python/apache/thermos/observer/task_observer.py 6e7517b9f1b70cef8b0400cd7769fbbe7495dc42
Diff: https://reviews.apache.org/r/31774/diff/
Testing
-------
mba=aurora=; ./pants test.pytest --no-fast src/test3/python::
Thanks,
Brian Wickman
Re: Review Request 31774: Add aurora-specific entry point for thermos
observer and fix /vars
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31774/
-----------------------------------------------------------
(Updated March 9, 2015, 9:24 p.m.)
Review request for Aurora, Joe Smith and Zameer Manji.
Changes
-------
remove the EndpointTracePlugin which is unused
Bugs: AURORA-1133
https://issues.apache.org/jira/browse/AURORA-1133
Repository: aurora
Description
-------
Just like the aurora-specific thermos entry point, adds an aurora-specific thermos_observer entry point. Just allows it to search for thermos runners in /var/lib/thermos and also relative to mesos sandboxes.
Diffs (updated)
-----
src/main/python/apache/aurora/tools/BUILD 36117b4199bc52873ca3abdb1ef6447437a81bb0
src/main/python/apache/aurora/tools/thermos_observer.py PRE-CREATION
src/main/python/apache/thermos/observer/BUILD 28995b99b4991e17eb977583388c89e753055e9b
src/main/python/apache/thermos/observer/bin/BUILD a42dbf321b8dcf5d64b22c2a480c3f4e3bad2a42
src/main/python/apache/thermos/observer/bin/thermos_observer.py 213a48eb4e2441b88fd6b608d1f3ba7dd0f2b859
src/main/python/apache/thermos/observer/http/BUILD cc8eb7793b980a6a4b76deece759e12e9bc7fcb0
src/main/python/apache/thermos/observer/http/configure.py PRE-CREATION
src/main/python/apache/thermos/observer/http/diagnostics.py PRE-CREATION
src/main/python/apache/thermos/observer/http/vars_endpoint.py PRE-CREATION
src/main/python/apache/thermos/observer/task_observer.py 6e7517b9f1b70cef8b0400cd7769fbbe7495dc42
Diff: https://reviews.apache.org/r/31774/diff/
Testing
-------
mba=aurora=; ./pants test.pytest --no-fast src/test3/python::
Thanks,
Brian Wickman
Re: Review Request 31774: Add aurora-specific entry point for thermos
observer and fix /vars
Posted by Joe Smith <ya...@gmail.com>.
> On March 5, 2015, 3:32 p.m., Zameer Manji wrote:
> > src/main/python/apache/thermos/observer/http/diagnostics.py, line 61
> > <https://reviews.apache.org/r/31774/diff/1/?file=886116#file886116line61>
> >
> > This duplicates some code in twitter.common.app. Is this code not available in the sdists?
It is not, apparently I still need to commit this [README.md](https://github.com/Yasumoto/commons/commit/af59f580624eddf104cdf380ddd956123ea19b15).
- Joe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31774/#review75414
-----------------------------------------------------------
On March 5, 2015, 12:31 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31774/
> -----------------------------------------------------------
>
> (Updated March 5, 2015, 12:31 p.m.)
>
>
> Review request for Aurora, Joe Smith and Zameer Manji.
>
>
> Bugs: AURORA-1133
> https://issues.apache.org/jira/browse/AURORA-1133
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Just like the aurora-specific thermos entry point, adds an aurora-specific thermos_observer entry point. Just allows it to search for thermos runners in /var/lib/thermos and also relative to mesos sandboxes.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/tools/BUILD 36117b4199bc52873ca3abdb1ef6447437a81bb0
> src/main/python/apache/aurora/tools/thermos_observer.py PRE-CREATION
> src/main/python/apache/thermos/observer/BUILD 28995b99b4991e17eb977583388c89e753055e9b
> src/main/python/apache/thermos/observer/bin/BUILD a42dbf321b8dcf5d64b22c2a480c3f4e3bad2a42
> src/main/python/apache/thermos/observer/bin/thermos_observer.py 213a48eb4e2441b88fd6b608d1f3ba7dd0f2b859
> src/main/python/apache/thermos/observer/http/BUILD cc8eb7793b980a6a4b76deece759e12e9bc7fcb0
> src/main/python/apache/thermos/observer/http/configure.py PRE-CREATION
> src/main/python/apache/thermos/observer/http/diagnostics.py PRE-CREATION
> src/main/python/apache/thermos/observer/http/vars_endpoint.py PRE-CREATION
> src/main/python/apache/thermos/observer/task_observer.py 6e7517b9f1b70cef8b0400cd7769fbbe7495dc42
>
> Diff: https://reviews.apache.org/r/31774/diff/
>
>
> Testing
> -------
>
> mba=aurora=; ./pants test.pytest --no-fast src/test3/python::
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 31774: Add aurora-specific entry point for thermos
observer and fix /vars
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31774/#review75414
-----------------------------------------------------------
src/main/python/apache/thermos/observer/http/diagnostics.py
<https://reviews.apache.org/r/31774/#comment122454>
Could we improve this to include stats like p99?
Also I don't see this class used anywhere, how does this plugin get registered?
src/main/python/apache/thermos/observer/http/diagnostics.py
<https://reviews.apache.org/r/31774/#comment122453>
This duplicates some code in twitter.common.app. Is this code not available in the sdists?
src/main/python/apache/thermos/observer/http/diagnostics.py
<https://reviews.apache.org/r/31774/#comment122452>
If we can import PEX, shouldn't this be impossible?
- Zameer Manji
On March 5, 2015, 12:31 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31774/
> -----------------------------------------------------------
>
> (Updated March 5, 2015, 12:31 p.m.)
>
>
> Review request for Aurora, Joe Smith and Zameer Manji.
>
>
> Bugs: AURORA-1133
> https://issues.apache.org/jira/browse/AURORA-1133
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Just like the aurora-specific thermos entry point, adds an aurora-specific thermos_observer entry point. Just allows it to search for thermos runners in /var/lib/thermos and also relative to mesos sandboxes.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/tools/BUILD 36117b4199bc52873ca3abdb1ef6447437a81bb0
> src/main/python/apache/aurora/tools/thermos_observer.py PRE-CREATION
> src/main/python/apache/thermos/observer/BUILD 28995b99b4991e17eb977583388c89e753055e9b
> src/main/python/apache/thermos/observer/bin/BUILD a42dbf321b8dcf5d64b22c2a480c3f4e3bad2a42
> src/main/python/apache/thermos/observer/bin/thermos_observer.py 213a48eb4e2441b88fd6b608d1f3ba7dd0f2b859
> src/main/python/apache/thermos/observer/http/BUILD cc8eb7793b980a6a4b76deece759e12e9bc7fcb0
> src/main/python/apache/thermos/observer/http/configure.py PRE-CREATION
> src/main/python/apache/thermos/observer/http/diagnostics.py PRE-CREATION
> src/main/python/apache/thermos/observer/http/vars_endpoint.py PRE-CREATION
> src/main/python/apache/thermos/observer/task_observer.py 6e7517b9f1b70cef8b0400cd7769fbbe7495dc42
>
> Diff: https://reviews.apache.org/r/31774/diff/
>
>
> Testing
> -------
>
> mba=aurora=; ./pants test.pytest --no-fast src/test3/python::
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 31774: Add aurora-specific entry point for thermos
observer and fix /vars
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31774/#review75417
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On March 5, 2015, 12:31 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31774/
> -----------------------------------------------------------
>
> (Updated March 5, 2015, 12:31 p.m.)
>
>
> Review request for Aurora, Joe Smith and Zameer Manji.
>
>
> Bugs: AURORA-1133
> https://issues.apache.org/jira/browse/AURORA-1133
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Just like the aurora-specific thermos entry point, adds an aurora-specific thermos_observer entry point. Just allows it to search for thermos runners in /var/lib/thermos and also relative to mesos sandboxes.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/tools/BUILD 36117b4199bc52873ca3abdb1ef6447437a81bb0
> src/main/python/apache/aurora/tools/thermos_observer.py PRE-CREATION
> src/main/python/apache/thermos/observer/BUILD 28995b99b4991e17eb977583388c89e753055e9b
> src/main/python/apache/thermos/observer/bin/BUILD a42dbf321b8dcf5d64b22c2a480c3f4e3bad2a42
> src/main/python/apache/thermos/observer/bin/thermos_observer.py 213a48eb4e2441b88fd6b608d1f3ba7dd0f2b859
> src/main/python/apache/thermos/observer/http/BUILD cc8eb7793b980a6a4b76deece759e12e9bc7fcb0
> src/main/python/apache/thermos/observer/http/configure.py PRE-CREATION
> src/main/python/apache/thermos/observer/http/diagnostics.py PRE-CREATION
> src/main/python/apache/thermos/observer/http/vars_endpoint.py PRE-CREATION
> src/main/python/apache/thermos/observer/task_observer.py 6e7517b9f1b70cef8b0400cd7769fbbe7495dc42
>
> Diff: https://reviews.apache.org/r/31774/diff/
>
>
> Testing
> -------
>
> mba=aurora=; ./pants test.pytest --no-fast src/test3/python::
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 31774: Add aurora-specific entry point for thermos
observer and fix /vars
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31774/#review75415
-----------------------------------------------------------
Ship it!
- Joe Smith
On March 5, 2015, 12:31 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31774/
> -----------------------------------------------------------
>
> (Updated March 5, 2015, 12:31 p.m.)
>
>
> Review request for Aurora, Joe Smith and Zameer Manji.
>
>
> Bugs: AURORA-1133
> https://issues.apache.org/jira/browse/AURORA-1133
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Just like the aurora-specific thermos entry point, adds an aurora-specific thermos_observer entry point. Just allows it to search for thermos runners in /var/lib/thermos and also relative to mesos sandboxes.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/tools/BUILD 36117b4199bc52873ca3abdb1ef6447437a81bb0
> src/main/python/apache/aurora/tools/thermos_observer.py PRE-CREATION
> src/main/python/apache/thermos/observer/BUILD 28995b99b4991e17eb977583388c89e753055e9b
> src/main/python/apache/thermos/observer/bin/BUILD a42dbf321b8dcf5d64b22c2a480c3f4e3bad2a42
> src/main/python/apache/thermos/observer/bin/thermos_observer.py 213a48eb4e2441b88fd6b608d1f3ba7dd0f2b859
> src/main/python/apache/thermos/observer/http/BUILD cc8eb7793b980a6a4b76deece759e12e9bc7fcb0
> src/main/python/apache/thermos/observer/http/configure.py PRE-CREATION
> src/main/python/apache/thermos/observer/http/diagnostics.py PRE-CREATION
> src/main/python/apache/thermos/observer/http/vars_endpoint.py PRE-CREATION
> src/main/python/apache/thermos/observer/task_observer.py 6e7517b9f1b70cef8b0400cd7769fbbe7495dc42
>
> Diff: https://reviews.apache.org/r/31774/diff/
>
>
> Testing
> -------
>
> mba=aurora=; ./pants test.pytest --no-fast src/test3/python::
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 31774: Add aurora-specific entry point for thermos
observer and fix /vars
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31774/#review75410
-----------------------------------------------------------
Master (70494a1) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 5, 2015, 8:31 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31774/
> -----------------------------------------------------------
>
> (Updated March 5, 2015, 8:31 p.m.)
>
>
> Review request for Aurora, Joe Smith and Zameer Manji.
>
>
> Bugs: AURORA-1133
> https://issues.apache.org/jira/browse/AURORA-1133
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Just like the aurora-specific thermos entry point, adds an aurora-specific thermos_observer entry point. Just allows it to search for thermos runners in /var/lib/thermos and also relative to mesos sandboxes.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/tools/BUILD 36117b4199bc52873ca3abdb1ef6447437a81bb0
> src/main/python/apache/aurora/tools/thermos_observer.py PRE-CREATION
> src/main/python/apache/thermos/observer/BUILD 28995b99b4991e17eb977583388c89e753055e9b
> src/main/python/apache/thermos/observer/bin/BUILD a42dbf321b8dcf5d64b22c2a480c3f4e3bad2a42
> src/main/python/apache/thermos/observer/bin/thermos_observer.py 213a48eb4e2441b88fd6b608d1f3ba7dd0f2b859
> src/main/python/apache/thermos/observer/http/BUILD cc8eb7793b980a6a4b76deece759e12e9bc7fcb0
> src/main/python/apache/thermos/observer/http/configure.py PRE-CREATION
> src/main/python/apache/thermos/observer/http/diagnostics.py PRE-CREATION
> src/main/python/apache/thermos/observer/http/vars_endpoint.py PRE-CREATION
> src/main/python/apache/thermos/observer/task_observer.py 6e7517b9f1b70cef8b0400cd7769fbbe7495dc42
>
> Diff: https://reviews.apache.org/r/31774/diff/
>
>
> Testing
> -------
>
> mba=aurora=; ./pants test.pytest --no-fast src/test3/python::
>
>
> Thanks,
>
> Brian Wickman
>
>