You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/07 11:19:24 UTC
[GitHub] [spark] ivoson opened a new pull request #35752: [SPARK-38434][SQL] Correct semantic of CheckAnalysis.getDataTypesAreCompatibleFn method
ivoson opened a new pull request #35752:
URL: https://github.com/apache/spark/pull/35752
### What changes were proposed in this pull request?
Modify the return value of method `CheckAnalysis.getDataTypesAreCompatibleFn`:
https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala#L606
Return true if data types are compatible, otherwise return false.
### Why are the changes needed?
Avoid the confusing of method definition.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Existing UT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ivoson commented on pull request #35752: [SPARK-38434][SQL] Correct semantic of CheckAnalysis.getDataTypesAreCompatibleFn method
Posted by GitBox <gi...@apache.org>.
ivoson commented on pull request #35752:
URL: https://github.com/apache/spark/pull/35752#issuecomment-1060562801
cc @gengliangwang @cloud-fan. Please take a look when you have time. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang closed pull request #35752: [SPARK-38434][SQL] Correct semantic of CheckAnalysis.getDataTypesAreCompatibleFn method
Posted by GitBox <gi...@apache.org>.
gengliangwang closed pull request #35752:
URL: https://github.com/apache/spark/pull/35752
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #35752: [SPARK-38434][SQL] Correct semantic of CheckAnalysis.getDataTypesAreCompatibleFn method
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #35752:
URL: https://github.com/apache/spark/pull/35752#issuecomment-1060733790
@ivoson thank you.
Merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org