You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/04/28 13:52:06 UTC
[jira] [Commented] (AMQ-5750) Add exception handler to
TaskRunnerFactory
[ https://issues.apache.org/jira/browse/AMQ-5750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516905#comment-14516905 ]
ASF GitHub Bot commented on AMQ-5750:
-------------------------------------
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq/pull/93
Added an uncaught exception handler to ThreadPoolExecutor
Added an uncaught exception handler to ThreadPoolExecutor getExecutor() method to log errors in threads.
This resolves https://issues.apache.org/jira/browse/AMQ-5750
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cshannon/activemq AMQ-5750
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq/pull/93.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #93
----
commit 10207ed1a8e0ad7a94dbf3dd523a270c2c5ded97
Author: Christopher L. Shannon (cshannon) <ch...@gmail.com>
Date: 2015-04-28T11:49:39Z
Added an uncaught exception handler to ThreadPoolExecutor getExecutor() method to log errors in threads.
This resolves https://issues.apache.org/jira/browse/AMQ-5750
----
> Add exception handler to TaskRunnerFactory
> ------------------------------------------
>
> Key: AMQ-5750
> URL: https://issues.apache.org/jira/browse/AMQ-5750
> Project: ActiveMQ
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 5.11.1
> Reporter: Christopher L. Shannon
> Priority: Minor
> Labels: easyfix
>
> The {{TaskRunnerFactory}} class in activemq-client creates a default executor but doesn't set an uncaught exception handler. This should be added so uncaught errors show up in the log for the created threads. This is similar to how the {{getExecutor}} method in {{BrokerService}} sets an uncaught exception handler.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)