You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/07/23 07:34:55 UTC

[GitHub] [zookeeper] ctubbsii commented on pull request #1311: Zookeeper 3415

ctubbsii commented on pull request #1311:
URL: https://github.com/apache/zookeeper/pull/1311#issuecomment-662861732


   @severussundar I'm not sure what best practice is, but I've noticed that the committers for this project tend to cherry-pick specific commits to specific maintenance branches. To make that easier for the committers to do, it may be worthwhile to rebase your PR onto the master branch and force-push to the branch you are doing the PR from (severussundar:ZOOKEEPER-3415). That way your changeset in this PR becomes a single commit. I've noticed such PRs tend to be merged faster, after receiving approvals... but that might be anecdotal.
   
   However, I don't want to lead you astray... so you may wish to first check with @eolivelli or @anmolnar , who are committers and are more familiar with the PR merge/cherry-pick strategy they use for accepting commits.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org