[GitHub] [dolphinscheduler] labbomb commented on a diff in pull request #9936: [Fix #9925]: fix ellipsis bug in table column

[GitBox <gi...@apache.org>]

labbomb commented on code in PR #9936:
URL: https://github.com/apache/dolphinscheduler/pull/9936#discussion_r867365884


##########
dolphinscheduler-ui/src/views/projects/list/use-table.ts:
##########
@@ -76,23 +76,22 @@ export function useTable() {
         title: t('project.list.project_name'),
         key: 'name',
         className: 'project-name',
-        ...COLUMN_WIDTH_CONFIG['name'],
+        width: 200,
         render: (row: { code: string; name: any }) =>
           h(
-            NEllipsis,
-            { style: 'max-width: 200px; color: #2080f0' },
+            ButtonLink,
+            {
+              onClick: () => {
+                router.push({ path: `/projects/${row.code}` })
+              }
+            },
             {
               default: () =>
                 h(
-                  ButtonLink,
-                  {
-                    onClick: () => {
-                      router.push({ path: `/projects/${row.code}` })
-                    }
-                  },
-                  { default: () => row.name }
-                ),
-              tooltip: () => row.name
+                  NEllipsis,
+                  { style: 'max-width: 180px;line-height: 1.5' },

Review Comment:
   Set width to the same as that specified in config, like: (max-width: 100px)



##########
dolphinscheduler-ui/src/views/projects/list/use-table.ts:
##########
@@ -76,23 +76,22 @@ export function useTable() {
         title: t('project.list.project_name'),
         key: 'name',
         className: 'project-name',
-        ...COLUMN_WIDTH_CONFIG['name'],

Review Comment:
   you'd better not delete the content of config



##########
dolphinscheduler-ui/src/views/projects/list/use-table.ts:
##########
@@ -76,23 +76,22 @@ export function useTable() {
         title: t('project.list.project_name'),
         key: 'name',
         className: 'project-name',
-        ...COLUMN_WIDTH_CONFIG['name'],
+        width: 200,

Review Comment:
   There's no need to add this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org