[jira] [Comment Edited] (OFBIZ-11167) Use Codenarc to test Groovy code

["Jacques Le Roux (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-11167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16962501#comment-16962501 ] 

Jacques Le Roux edited comment on OFBIZ-11167 at 11/4/19 10:57 AM:
-------------------------------------------------------------------

Hello [~jleroux] , [~mthl] and others

I did play a bit with codenarc and got a first step integration.

You can find attached the gradle integration and a custom rule file with all of the provided rules fount here : [http://codenarc.sourceforge.net/StarterRuleSet-AllRulesByCategory.groovy.txt] (i needed to remove some rules that where not recognized, since codenarc last revision is provided with upcoming gradle 6).

I attached the results against trunk, each file described every rule violations with the rule references at the bottom of the page.

I will take a look more closely in the next days/week, to clean up rules for OFBiz :)

Regards


was (Author: gil portenseigne):
Hello [~jleroux] , [~mthl] and others

I did play a bit with codenarc and got a first step integration.

You can find attached the gradle integration and a custom rule file with all of the provided rules fount here : [http://codenarc.sourceforge.net/StarterRuleSet-AllRulesByCategory.groovy.txt] (i needed to remove some rules that where not recognized, since codenarc last revision is provided with upcoming gradle 6).

I attached the results against trunk, each file described every rule violations with the rule references at the bottom of the page.

I will take a look more closely in the next days/week, to clean up rules for OFBiz :)

Regards

 

 

 

> Use Codenarc to test Groovy code
> --------------------------------
>
>                 Key: OFBIZ-11167
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11167
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Jacques Le Roux
>            Assignee: Gil Portenseigne
>            Priority: Minor
>         Attachments: OFBIZ-11167.patch, main.html, test.html
>
>
> Now that we use Groovy more and more, I think we should really have a look a Codenarc
> https://docs.gradle.org/current/userguide/codenarc_plugin.html
> We already discussed it at https://markmail.org/message/uigcpnxqgizhd2oi and https://markmail.org/message/rp6njoiohkkiodbe
> We know it's a crucial task but not an easy but rather a long term one
> Here are some interesting links (before I delete my FF tabs group about it)
> http://codenarc.sourceforge.net/codenarc-other-tools-frameworks.html
> http://codenarc.sourceforge.net/codenarc-creating-ruleset.html
> https://github.com/gradle/gradle/tree/master/config
> https://stackoverflow.com/questions/14358471/how-to-generate-codenarc-report-for-main-and-test-classes-using-different-rule-s
> https://mrhaki.blogspot.com/2011/01/gradle-goodness-use-groovy-ruleset-file.html



--
This message was sent by Atlassian Jira
(v8.3.4#803005)