You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@annotator.apache.org by GitBox <gi...@apache.org> on 2020/08/17 10:36:52 UTC

[GitHub] [incubator-annotator] Treora commented on issue #80: highlight range: "not a perfect undo: split text nodes are not merged again"

Treora commented on issue #80:
URL: https://github.com/apache/incubator-annotator/issues/80#issuecomment-674803745


   > Is there any action here, or are we okay to leave the nodes split?
   
   I ended up thinking that running e.g. `range.commonAncestorContainer.normalize()` in the cleanup would be a bit much; I’d rather not merge nodes we did not touch. We only split the start node and/or end node, and could change the implementation to just merge those nodes we split. This change simply did not seem a priority yet.
   
   I just added a comment for now to suggest running `range.commonAncestorContainer.normalize()`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org