You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/01/31 23:04:33 UTC
[GitHub] [incubator-superset] rusackas opened a new pull request #9063:
Removing (unused?) Victory theme file
rusackas opened a new pull request #9063: Removing (unused?) Victory theme file
URL: https://github.com/apache/incubator-superset/pull/9063
### CATEGORY
Choose one
- [ ] Bug Fix
- [ ] Enhancement (new features, refinement)
- [x] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
Just stumbled upon this theme file for [Victory](https://formidable.com/open-source/victory/docs/victory-theme/) which doesn't seem to be used or referred to anywhere in `incubator-superset` or `superset-ui` or `superset-ui-plugins` insofar as I can tell.
Should be safe to delete this, unless... I'm mistaken :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch merged pull request #9063:
Removing (unused?) Victory theme file
Posted by GitBox <gi...@apache.org>.
mistercrunch merged pull request #9063: Removing (unused?) Victory theme file
URL: https://github.com/apache/incubator-superset/pull/9063
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9063: Removing
(unused?) Victory theme file
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9063: Removing (unused?) Victory theme file
URL: https://github.com/apache/incubator-superset/pull/9063#issuecomment-580963108
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9063?src=pr&el=h1) Report
> Merging [#9063](https://codecov.io/gh/apache/incubator-superset/pull/9063?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/bbe433784d232538a9ed17edb9d7e5aaa0f39b0d?src=pr&el=desc) will **increase** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9063?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9063 +/- ##
==========================================
+ Coverage 59.45% 59.51% +0.06%
==========================================
Files 369 368 -1
Lines 11747 11734 -13
Branches 2888 2888
==========================================
Hits 6984 6984
+ Misses 4584 4571 -13
Partials 179 179
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9063?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9063?src=pr&el=footer). Last update [bbe4337...0bcba0b](https://codecov.io/gh/apache/incubator-superset/pull/9063?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org