You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "Mike Drob (JIRA)" <ji...@apache.org> on 2014/01/06 22:53:51 UTC

[jira] [Comment Edited] (ACCUMULO-2126) Hadoop profile names should be consistent across branches

    [ https://issues.apache.org/jira/browse/ACCUMULO-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13863471#comment-13863471 ] 

Mike Drob edited comment on ACCUMULO-2126 at 1/6/14 9:52 PM:
-------------------------------------------------------------

{{mvn package -Dhadoop.profile=1 && mvn package -Dhadoop.profile=2}} fails, but I think that's unavoidable.

Can you strengthen the comment {{+        <!-- Just to denote intention, won't work to activate profile -->}}, since it is now required, in order for the enforcer plug-in to validate?

Everything else looks good!


was (Author: mdrob):
{{mvn package -Dhadoop.profile=1 && mvn package -Dhadoop.profile=2}} fails, but I think that's unavoidable.

Can you strengthen the comment {{+        <!-- Just to denote intention, won't work to activate profile -->}}, since it is not required, in order for the enforcer plug-in to validate?

Everything else looks good!

> Hadoop profile names should be consistent across branches
> ---------------------------------------------------------
>
>                 Key: ACCUMULO-2126
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2126
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: build
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Minor
>             Fix For: 1.4.5, 1.5.1, 1.6.0
>
>         Attachments: ACCUMULO-2126.1-1.5.1-SNAPSHOT.patch.txt, ACCUMULO-2126.1-1.6.0-SNAPSHOT.patch.txt, ACCUMULO-2126.1.patch.txt, ACCUMULO-2126.2-1.5.1-SNAPSHOT.patch.txt, ACCUMULO-2126.2-1.6.0-SNAPSHOT.patch.txt, ACCUMULO-2126.2.patch.txt
>
>
> ACCUMULO-1419 changed the hadoop pofile names to reflect the major components used. This makes documenting how to build against a major hadoop line across all of our branches more difficult than necessary.
> Since the changes in what we need to do vary with the Hadoop line, e.g. Hadoop 1 and Hadoop 2, we should name them appropriately.
> Additionally, our current activation scheme for hte default doesn't allow activating it by name.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)