You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by StephanEwen <gi...@git.apache.org> on 2017/02/14 21:34:49 UTC

[GitHub] flink pull request #3312: [FLINK-5800] [checkpointing] Create CheckpointStea...

GitHub user StephanEwen opened a pull request:

    https://github.com/apache/flink/pull/3312

    [FLINK-5800] [checkpointing] Create CheckpointSteamFactory only once per operator

    Previously, the factory was created once per checkpoint, and its repeated initialization logic
    (like ensuring existence of base paths) caused heavy load on some filesystems at very large scale.
    
    This issue was reported by (and the solution suggested by) Steven Wu.
    
    ## Core Changes
    
    The `CheckpointStreamFactory` is now created once per operator upon initialization of the operator. The factory is also stored in the operator, alongside the `KeyedStateBackend` and the `OperatorStateBackend`.
    
    ## Tests
    
    This change does not introduce new functionality, but simply re-arranges current tests to handle and check the changes instantiation of the CheckpointStreamFactory.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/StephanEwen/incubator-flink stream_factory

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3312.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3312
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3312: [FLINK-5800] [checkpointing] Create CheckpointStea...

Posted by uce <gi...@git.apache.org>.
Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3312#discussion_r101271401
  
    --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/util/AbstractStreamOperatorTestHarness.java ---
    @@ -513,7 +509,9 @@ public void notifyOfCompletedCheckpoint(long checkpointId) throws Exception {
     	/**
     	 * Calls {@link StreamCheckpointedOperator#restoreState(FSDataInputStream)} if
     	 * the operator implements this interface.
    -	 */	@Deprecated
    +	 */
    +	@Deprecated
    +	
    --- End diff --
    
    empty line


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3312: [FLINK-5800] [checkpointing] Create CheckpointStea...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/3312


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---