You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2011/12/10 19:19:42 UTC

[jira] [Commented] (FLUME-880) HDFSFormatterFactory is using == operator for String objects

    [ https://issues.apache.org/jira/browse/FLUME-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166919#comment-13166919 ] 

jiraposter@reviews.apache.org commented on FLUME-880:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3145/
-----------------------------------------------------------

Review request for Flume and Eric Sammer.


Summary
-------

I've just changed operator == to method call equalsIgnoreCase().


This addresses bug FLUME-880.
    https://issues.apache.org/jira/browse/FLUME-880


Diffs
-----

  /branches/flume-728/flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSFormatterFactory.java 1212827 

Diff: https://reviews.apache.org/r/3145/diff


Testing
-------

I've test it on my testing cluster. No formal test cases were added.


Thanks,

Jarek


                
> HDFSFormatterFactory is using == operator for String objects
> ------------------------------------------------------------
>
>                 Key: FLUME-880
>                 URL: https://issues.apache.org/jira/browse/FLUME-880
>             Project: Flume
>          Issue Type: Bug
>          Components: Sinks+Sources
>    Affects Versions: NG alpha 3
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Jarek Jarcec Cecho
>            Priority: Minor
>
> Factory class HDFSFormatterFactory is using operator == for  comparing String objects.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira