You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/09/19 17:25:53 UTC
[GitHub] [druid] jon-wei opened a new pull request, #13122: Add KafkaConfigOverrides extension point
jon-wei opened a new pull request, #13122:
URL: https://github.com/apache/druid/pull/13122
This PR adds a new `KafkaConfigOverrides` extension point, which defines an interface for a `configOverrides` object in the Kafka supervisor spec's IOConfig. This interface allows an extension to provide an implementation that if defined in the supervisor spec, gets access to the Kafka consumer properties map, and can return a freely modified version of the consumer properties.
This is useful for extensions that do operations such as removing forbidden consumer properties from being set, or adding additional consumer properties (such as referencing an external secrets manager for sensitive properties).
This PR has:
- [x] been self-reviewed.
- [ ] added documentation for new or modified features or behaviors.
- [x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [x] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] 2bethere commented on pull request #13122: Add KafkaConfigOverrides extension point
Posted by GitBox <gi...@apache.org>.
2bethere commented on PR #13122:
URL: https://github.com/apache/druid/pull/13122#issuecomment-1281646136
@jon-wei do you mind adding an example into the docs for this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 merged pull request #13122: Add KafkaConfigOverrides extension point
Posted by GitBox <gi...@apache.org>.
abhishekagarwal87 merged PR #13122:
URL: https://github.com/apache/druid/pull/13122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org