You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/30 10:16:35 UTC
[GitHub] [arrow-rs] alamb opened a new pull request, #2238: [Minor] Improve Schema metadata mismatch error
alamb opened a new pull request, #2238:
URL: https://github.com/apache/arrow-rs/pull/2238
# Which issue does this PR close?
N/A
# Rationale for this change
See https://github.com/apache/arrow-datafusion/issues/2982
The error just says "schema metadata mismatch" but does not explain what is mismatched.
# What changes are included in this PR?
Add details to the error message, and PR just makes the error clearer and explains what is conflicting about the schema
# Are there any user-facing changes?
Better error message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #2238: [Minor] Improve Schema metadata mismatch error
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2238:
URL: https://github.com/apache/arrow-rs/pull/2238#issuecomment-1200132818
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/2238?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2238](https://codecov.io/gh/apache/arrow-rs/pull/2238?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6047976) into [master](https://codecov.io/gh/apache/arrow-rs/commit/445283c83b547744caf20a65ef0693327fdbed81?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (445283c) will **decrease** coverage by `0.30%`.
> The diff coverage is `72.72%`.
```diff
@@ Coverage Diff @@
## master #2238 +/- ##
==========================================
- Coverage 82.61% 82.30% -0.31%
==========================================
Files 239 240 +1
Lines 62272 62440 +168
==========================================
- Hits 51444 51391 -53
- Misses 10828 11049 +221
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/2238?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [arrow/src/datatypes/schema.rs](https://codecov.io/gh/apache/arrow-rs/pull/2238/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2RhdGF0eXBlcy9zY2hlbWEucnM=) | `69.41% <40.00%> (-4.05%)` | :arrow_down: |
| [arrow/src/datatypes/mod.rs](https://codecov.io/gh/apache/arrow-rs/pull/2238/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2RhdGF0eXBlcy9tb2QucnM=) | `99.25% <100.00%> (+<0.01%)` | :arrow_up: |
| [arrow/src/array/array\_string.rs](https://codecov.io/gh/apache/arrow-rs/pull/2238/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2FycmF5X3N0cmluZy5ycw==) | `92.05% <0.00%> (-5.01%)` | :arrow_down: |
| [arrow/src/array/builder/generic\_list\_builder.rs](https://codecov.io/gh/apache/arrow-rs/pull/2238/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2J1aWxkZXIvZ2VuZXJpY19saXN0X2J1aWxkZXIucnM=) | `92.59% <0.00%> (-2.47%)` | :arrow_down: |
| [arrow/src/array/builder/primitive\_builder.rs](https://codecov.io/gh/apache/arrow-rs/pull/2238/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2J1aWxkZXIvcHJpbWl0aXZlX2J1aWxkZXIucnM=) | `94.21% <0.00%> (-1.06%)` | :arrow_down: |
| [parquet/src/column/writer/encoder.rs](https://codecov.io/gh/apache/arrow-rs/pull/2238/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvY29sdW1uL3dyaXRlci9lbmNvZGVyLnJz) | `87.65% <0.00%> (-0.81%)` | :arrow_down: |
| [parquet/src/arrow/arrow\_reader.rs](https://codecov.io/gh/apache/arrow-rs/pull/2238/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvYXJyb3cvYXJyb3dfcmVhZGVyLnJz) | `95.00% <0.00%> (-0.72%)` | :arrow_down: |
| [...rquet/src/arrow/record\_reader/definition\_levels.rs](https://codecov.io/gh/apache/arrow-rs/pull/2238/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvYXJyb3cvcmVjb3JkX3JlYWRlci9kZWZpbml0aW9uX2xldmVscy5ycw==) | `88.60% <0.00%> (-0.43%)` | :arrow_down: |
| [parquet/src/encodings/rle.rs](https://codecov.io/gh/apache/arrow-rs/pull/2238/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvZW5jb2RpbmdzL3JsZS5ycw==) | `92.42% <0.00%> (-0.37%)` | :arrow_down: |
| ... and [34 more](https://codecov.io/gh/apache/arrow-rs/pull/2238/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #2238: [Minor] Improve Schema metadata mismatch error
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #2238:
URL: https://github.com/apache/arrow-rs/pull/2238#issuecomment-1203752067
Benchmark runs are scheduled for baseline = 577a93babf5806f7cc6425bf81e6980de493f77f and contender = b8261629f3d197c5bc40e66a0356a51706ebab96. b8261629f3d197c5bc40e66a0356a51706ebab96 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/bc675d59c6304d4d9fb6e41a1578ed11...02e760b762824da3b9a884291e338d15/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/62e6143f8e3344f682c37604c77f8daf...70a1982f5c3a42158a4331a90151e537/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/3925410bb003456bbae24cbe7da354ee...07b3c7d0ab8f402da19499eae4431c6e/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/7b8dde25069149a0a3a2dcd76c335cba...dfb330cbb2cf437aa33f175f6b63913f/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #2238: [Minor] Improve Schema metadata mismatch error
Posted by GitBox <gi...@apache.org>.
alamb merged PR #2238:
URL: https://github.com/apache/arrow-rs/pull/2238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org