[jira] Issue Comment Edited: (DIRMINA-463) Find the best way to specify both MINA and non-MINA events.

["Trustin Lee (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DIRMINA-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540330 ] 

trustin edited comment on DIRMINA-463 at 11/5/07 8:44 PM:
--------------------------------------------------------------

Excellent!  and a few tiny comments... :)

1) We are now tightly-coupled with mina-core.  Are you sure about this?
2) WDYT about removing FILTER_ prefix to get aligned with org.apache.mina.common.IoEventType?

      was (Author: trustin):
    A few comments:

1) We are now tightly-coupled with mina-core.  Are you sure about this?
2) WDYT about removing FILTER_ prefix to get aligned with org.apache.mina.common.IoEventType?
  
> Find the best way to specify both MINA and non-MINA events.
> -----------------------------------------------------------
>
>                 Key: DIRMINA-463
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-463
>             Project: MINA
>          Issue Type: Task
>          Components: Statemachine
>            Reporter: Trustin Lee
>            Assignee: Niklas Therning
>            Priority: Minor
>             Fix For: 2.0.0-M1
>
>
> As discussed here: http://tinyurl.com/2omrl9
> For now, we use String to identify event types, which is somewhat unsafe.  Using an enum might be useful, but there are a few disadvantages:
> * Wildcard event type cannot be used, which could be extended further (e.g. "message*" or "session(Opened|Closed)")
> Probably sticking to String might be the best solution? :)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.