You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Brian Towles via Review Board <no...@reviews.apache.org> on 2018/11/07 21:57:46 UTC
Review Request 69285: Signal Handle Unregister
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69285/
-----------------------------------------------------------
Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na Li, Steve Moist, and Sergio Pena.
Bugs: SENTRY-2444
https://issues.apache.org/jira/browse/SENTRY-2444
Repository: sentry
Description
-------
SENTRY-2444: Signal Handle Unregister
Single unregister of function from the signal handler.
Diffs
-----
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/SigUtils.java d621c74c2cdf44c1eedbec36f5cd8a32cace20ff
Diff: https://reviews.apache.org/r/69285/diff/1/
Testing
-------
Build and Unit tests
Thanks,
Brian Towles
Re: Review Request 69285: Signal Handle Unregister
Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69285/#review211003
-----------------------------------------------------------
Ship it!
Ship It!
- Sergio Pena
On Nov. 19, 2018, 4:32 p.m., Brian Towles wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69285/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2018, 4:32 p.m.)
>
>
> Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na Li, Steve Moist, and Sergio Pena.
>
>
> Bugs: SENTRY-2444
> https://issues.apache.org/jira/browse/SENTRY-2444
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-2444: Signal Handle Unregister
>
> Single unregister of function from the signal handler.
>
>
> Diffs
> -----
>
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/SigUtils.java d621c74c2
>
>
> Diff: https://reviews.apache.org/r/69285/diff/2/
>
>
> Testing
> -------
>
> Build and Unit tests
>
>
> Thanks,
>
> Brian Towles
>
>
Re: Review Request 69285: Signal Handle Unregister
Posted by Steve Moist via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69285/#review210670
-----------------------------------------------------------
Ship it!
Ship It!
- Steve Moist
On Nov. 19, 2018, 4:32 p.m., Brian Towles wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69285/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2018, 4:32 p.m.)
>
>
> Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na Li, Steve Moist, and Sergio Pena.
>
>
> Bugs: SENTRY-2444
> https://issues.apache.org/jira/browse/SENTRY-2444
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-2444: Signal Handle Unregister
>
> Single unregister of function from the signal handler.
>
>
> Diffs
> -----
>
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/SigUtils.java d621c74c2
>
>
> Diff: https://reviews.apache.org/r/69285/diff/2/
>
>
> Testing
> -------
>
> Build and Unit tests
>
>
> Thanks,
>
> Brian Towles
>
>
Re: Review Request 69285: Signal Handle Unregister
Posted by Brian Towles via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69285/
-----------------------------------------------------------
(Updated Nov. 19, 2018, 10:32 a.m.)
Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na Li, Steve Moist, and Sergio Pena.
Changes
-------
Fixes for Steve
Bugs: SENTRY-2444
https://issues.apache.org/jira/browse/SENTRY-2444
Repository: sentry
Description
-------
SENTRY-2444: Signal Handle Unregister
Single unregister of function from the signal handler.
Diffs (updated)
-----
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/SigUtils.java d621c74c2
Diff: https://reviews.apache.org/r/69285/diff/2/
Changes: https://reviews.apache.org/r/69285/diff/1-2/
Testing
-------
Build and Unit tests
Thanks,
Brian Towles
Re: Review Request 69285: Signal Handle Unregister
Posted by Brian Towles via Review Board <no...@reviews.apache.org>.
> On Nov. 7, 2018, 4:15 p.m., Steve Moist wrote:
> > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/SigUtils.java
> > Lines 120 (patched)
> > <https://reviews.apache.org/r/69285/diff/1/?file=2106285#file2106285line120>
> >
> > Reverse these checks to match the parameter order.
Changed, but Really?
- Brian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69285/#review210387
-----------------------------------------------------------
On Nov. 19, 2018, 10:32 a.m., Brian Towles wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69285/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2018, 10:32 a.m.)
>
>
> Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na Li, Steve Moist, and Sergio Pena.
>
>
> Bugs: SENTRY-2444
> https://issues.apache.org/jira/browse/SENTRY-2444
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-2444: Signal Handle Unregister
>
> Single unregister of function from the signal handler.
>
>
> Diffs
> -----
>
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/SigUtils.java d621c74c2
>
>
> Diff: https://reviews.apache.org/r/69285/diff/2/
>
>
> Testing
> -------
>
> Build and Unit tests
>
>
> Thanks,
>
> Brian Towles
>
>
Re: Review Request 69285: Signal Handle Unregister
Posted by Steve Moist via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69285/#review210387
-----------------------------------------------------------
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/SigUtils.java
Lines 120 (patched)
<https://reviews.apache.org/r/69285/#comment295048>
Reverse these checks to match the parameter order.
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/SigUtils.java
Lines 123 (patched)
<https://reviews.apache.org/r/69285/#comment295049>
StringUtils.isEmpty
- Steve Moist
On Nov. 7, 2018, 9:57 p.m., Brian Towles wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69285/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2018, 9:57 p.m.)
>
>
> Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na Li, Steve Moist, and Sergio Pena.
>
>
> Bugs: SENTRY-2444
> https://issues.apache.org/jira/browse/SENTRY-2444
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-2444: Signal Handle Unregister
>
> Single unregister of function from the signal handler.
>
>
> Diffs
> -----
>
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/SigUtils.java d621c74c2cdf44c1eedbec36f5cd8a32cace20ff
>
>
> Diff: https://reviews.apache.org/r/69285/diff/1/
>
>
> Testing
> -------
>
> Build and Unit tests
>
>
> Thanks,
>
> Brian Towles
>
>