You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "b-goyal (via GitHub)" <gi...@apache.org> on 2024/03/14 11:58:14 UTC
Re: [PR] KAFKA-2072 [WIP]: Add StopReplica request/response to o.a.k.common.requests and replace the usage in core module [kafka]
b-goyal commented on PR #141:
URL: https://github.com/apache/kafka/pull/141#issuecomment-1997281107
Migration is done but this PR will need to be rebased on #110. I have copied some code (ef669a5) for now.
I'd appreciate feedback on it mainly around how I handle things in the ControllerChannelManager. I have introduced a new 'sendRequest' method for o.a.k.common.requests and kept the old one for compatibility reason. We'll be able to remove the old one in the future when migration of all requests and responses to o.a.k.common.requests is completed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org