[jira] [Commented] (LUCENE-10644) Facets#getAllChildren testing should ignore child order

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-10644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17581463#comment-17581463 ] 

ASF subversion and git services commented on LUCENE-10644:
----------------------------------------------------------

Commit 0914b537dbfb1ecd49bfb90c27df69a67e50c327 in lucene's branch refs/heads/main from Yuting Gan
[ https://gitbox.apache.org/repos/asf?p=lucene.git;h=0914b537dbf ]

LUCENE-10644: Facets#getAllChildren testing should ignore child order (#1013)



> Facets#getAllChildren testing should ignore child order
> -------------------------------------------------------
>
>                 Key: LUCENE-10644
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10644
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/facet
>            Reporter: Greg Miller
>            Priority: Minor
>         Attachments: failing tests.png
>
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> Our javadoc for {{Facets#getAllChildren}} explicitly calls out that callers should make no assumptions about child ordering, but a number of our own unit tests turn around and make that assumption. I ran into this when recently trying an optimization that would result in a different child ordering for {{{}getAllChildren{}}}, and found a number of unit tests that started failing. I'll upload a list of what I found failing.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org