You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by we...@apache.org on 2017/07/03 17:44:32 UTC

arrow git commit: ARROW-1180: [GLib] Fix a returning invalid address bug in garrow_tensor_get_dimension_name()

Repository: arrow
Updated Branches:
  refs/heads/master 2c3e8b09d -> a6d0c2654


ARROW-1180: [GLib] Fix a returning invalid address bug in garrow_tensor_get_dimension_name()

See also: https://github.com/apache/arrow/pull/783#pullrequestreview-46377983

Author: Kouhei Sutou <ko...@clear-code.com>

Closes #804 from kou/glib-fix-tensor-dimension-name and squashes the following commits:

5740be3f [Kouhei Sutou] [GLib] Fix a returning invalid address bug in garrow_tensor_get_dimension_name()


Project: http://git-wip-us.apache.org/repos/asf/arrow/repo
Commit: http://git-wip-us.apache.org/repos/asf/arrow/commit/a6d0c265
Tree: http://git-wip-us.apache.org/repos/asf/arrow/tree/a6d0c265
Diff: http://git-wip-us.apache.org/repos/asf/arrow/diff/a6d0c265

Branch: refs/heads/master
Commit: a6d0c2654742b1cec4aa186ec9a430e28fd3d4af
Parents: 2c3e8b0
Author: Kouhei Sutou <ko...@clear-code.com>
Authored: Mon Jul 3 13:44:28 2017 -0400
Committer: Wes McKinney <we...@twosigma.com>
Committed: Mon Jul 3 13:44:28 2017 -0400

----------------------------------------------------------------------
 c_glib/arrow-glib/tensor.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/arrow/blob/a6d0c265/c_glib/arrow-glib/tensor.cpp
----------------------------------------------------------------------
diff --git a/c_glib/arrow-glib/tensor.cpp b/c_glib/arrow-glib/tensor.cpp
index 89e971c..3325f85 100644
--- a/c_glib/arrow-glib/tensor.cpp
+++ b/c_glib/arrow-glib/tensor.cpp
@@ -314,8 +314,8 @@ const gchar *
 garrow_tensor_get_dimension_name(GArrowTensor *tensor, gint i)
 {
   auto arrow_tensor = garrow_tensor_get_raw(tensor);
-  auto arrow_dimension_name = arrow_tensor->dim_name(i);
-  return arrow_dimension_name.c_str();
+  auto arrow_dimension_name = &(arrow_tensor->dim_name(i));
+  return arrow_dimension_name->c_str();
 }
 
 /**